Modify SkLazyPixelRef to use SkImageGenerator.

Modify SkLazyPixelRef to use SkImageGenerator.

Add SkMallocPixelRef::Install for symmetry with other PixelRefs.

Modify SkBitmapFactory to use new improved SkLazyPixelRef (later
changes will change the SkBitmapFactory interface.)

To do:  find out if anyone uses SkBitmapFactory and SkImageCache.

Modify unit tests to reflect new reality.

Fix some cpplint problems in the files I touched.

BUG=

[reed1, 2013-11-25 18:06:56]

https://codereview.chromium.org/83663006/diff/70001/include/core/SkMallocPixe...
File include/core/SkMallocPixelRef.h (right):

https://codereview.chromium.org/83663006/diff/70001/include/core/SkMallocPixe...
include/core/SkMallocPixelRef.h:49: virtual void* onLockPixels(SkColorTable**
colorTable);
It is ok to leave off these parameter variable names when they don't convey any
more info (other than th e type).

It is also ok to include them, but seems unnecessary.

https://codereview.chromium.org/83663006/diff/70001/src/core/SkMallocPixelRef...
File src/core/SkMallocPixelRef.cpp (right):

https://codereview.chromium.org/83663006/diff/70001/src/core/SkMallocPixelRef...
src/core/SkMallocPixelRef.cpp:49: void* pixels = sk_malloc_throw(size);
Can we change this to sk_malloc_flags() so we can return NULL on allocation
failure?

https://codereview.chromium.org/83663006/diff/70001/src/lazy/SkBitmapFactory.cpp
File src/lazy/SkBitmapFactory.cpp (right):

https://codereview.chromium.org/83663006/diff/70001/src/lazy/SkBitmapFactory....
src/lazy/SkBitmapFactory.cpp:50: class FlexibleGenerator : public
SkImageGenerator {
Not sure why this is named Flexible. Can you add a comment-block above the
class?

https://codereview.chromium.org/83663006/diff/70001/src/lazy/SkLazyPixelRef.h
File src/lazy/SkLazyPixelRef.h (right):

https://codereview.chromium.org/83663006/diff/70001/src/lazy/SkLazyPixelRef.h...
src/lazy/SkLazyPixelRef.h:33: static bool Install(SkImageGenerator*,
SkImageCache*, SkBitmap* dst);
Do we still support SkImageCache?

[scroggo, 2013-12-02 19:03:23]

Are you still working on this one, or should I just be looking at
https://codereview.chromium.org/84783002/ ?

https://codereview.chromium.org/83663006/diff/70001/include/core/SkMallocPixe...
File include/core/SkMallocPixelRef.h (right):

https://codereview.chromium.org/83663006/diff/70001/include/core/SkMallocPixe...
include/core/SkMallocPixelRef.h:37: static bool Install(SkImageGenerator*
generator, SkBitmap* destination);
Is there a reason these changes aren't included in
https://codereview.chromium.org/84783002/ ?

[hal.canary, 2013-12-02 19:04:50]

On 2013/12/02 19:03:23, scroggo wrote:
> Are you still working on this one, or should I just be looking at
> https://codereview.chromium.org/84783002/ ?
> 
>
https://codereview.chromium.org/83663006/diff/70001/include/core/SkMallocPixe...
> File include/core/SkMallocPixelRef.h (right):
> 
>
https://codereview.chromium.org/83663006/diff/70001/include/core/SkMallocPixe...
> include/core/SkMallocPixelRef.h:37: static bool Install(SkImageGenerator*
> generator, SkBitmap* destination);
> Is there a reason these changes aren't included in
> https://codereview.chromium.org/84783002/ ?

I am not working on this one anymore.  Mike and I determined that since noone is
using SkBitmapFactory and SkLazyPixelRef, we can do away with those classes.

[scroggo, 2013-12-02 19:06:51]

On 2013/12/02 19:04:50, Hal Canary wrote:
> On 2013/12/02 19:03:23, scroggo wrote:
> > Are you still working on this one, or should I just be looking at
> > https://codereview.chromium.org/84783002/ ?
> > 
> >
>
https://codereview.chromium.org/83663006/diff/70001/include/core/SkMallocPixe...
> > File include/core/SkMallocPixelRef.h (right):
> > 
> >
>
https://codereview.chromium.org/83663006/diff/70001/include/core/SkMallocPixe...
> > include/core/SkMallocPixelRef.h:37: static bool Install(SkImageGenerator*
> > generator, SkBitmap* destination);
> > Is there a reason these changes aren't included in
> > https://codereview.chromium.org/84783002/ ?
> 
> I am not working on this one anymore.  Mike and I determined that since noone
is
> using SkBitmapFactory and SkLazyPixelRef, we can do away with those classes.

sgtm!