Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(180)

Issue 836613008: [fsp] Fix flaky tests for aborting read. (Closed)

Created:
5 years, 11 months ago by mtomasz
Modified:
5 years, 11 months ago
Reviewers:
yawano
CC:
chromium-reviews, chromium-apps-reviews_chromium.org, extensions-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[fsp] Fix flaky tests for aborting read. If reading is aborted before the file is opened, then obviously abort event is not dispatched to the providing extension, as there is no operation to abort. This patch fixes this race by waiting until the read operation is started, so the abort event will be always dispatched. TEST=browser_tests: *FileSystemProvider*ReadFile* BUG=None Committed: https://crrev.com/8a1436c88f0bc8f6ab62649ed1a9a102f429e9af Cr-Commit-Position: refs/heads/master@{#310745}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+28 lines, -26 lines) Patch
M chrome/test/data/extensions/api_test/file_system_provider/read_file/test.js View 3 chunks +28 lines, -26 lines 0 comments Download

Messages

Total messages: 8 (2 generated)
mtomasz
@yawano: One more small quick fix for a recent CL. PTAL. Thanks.
5 years, 11 months ago (2015-01-09 08:25:43 UTC) #2
yawano
lgtm. Thank you!
5 years, 11 months ago (2015-01-09 08:34:59 UTC) #3
mtomasz
Thanks for fast response!
5 years, 11 months ago (2015-01-09 08:37:10 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/836613008/1
5 years, 11 months ago (2015-01-09 08:37:26 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 11 months ago (2015-01-09 09:34:03 UTC) #7
commit-bot: I haz the power
5 years, 11 months ago (2015-01-09 09:35:24 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/8a1436c88f0bc8f6ab62649ed1a9a102f429e9af
Cr-Commit-Position: refs/heads/master@{#310745}

Powered by Google App Engine
This is Rietveld 408576698