Issue 8366024: Add pnacl-gcc generated code back into the callingconv test mix

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 8366024: Add pnacl-gcc generated code back into the callingconv test mix (Closed)

Created:
9 years, 2 months ago by pdox

Modified:
9 years, 2 months ago

Reviewers:
jvoung - send to chromium..., (google.com) Derek Schuff

CC:
native-client-reviews_googlegroups.com

Base URL:
svn://svn.chromium.org/native_client/trunk/src/native_client/

Visibility:
Public.

Description

Test intermixing pnacl-clang, pnacl-gcc, and nacl-gcc generated code in the callingconv test. Although a large part of the callingconv test remains disabled due to known ABI compatibility problems, eventually this test will help detect and prevent ABI changes. Committed: http://src.chromium.org/viewvc/native_client?view=rev&revision=6999

Patch Set 1 #

Patch Set 2 : '' #

Created: 9 years, 2 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+59 lines, -32 lines)			Patch
M	site_scons/site_tools/naclsdk.py	View	2 chunks	+14 lines, -0 lines	0 comments	Download
M	tests/callingconv/callingconv.c	View	1 chunk	+12 lines, -8 lines	0 comments	Download
M	tests/callingconv/generate.py	View	1 chunk	+6 lines, -4 lines	0 comments	Download
M	tests/callingconv/nacl.scons	View	4 chunks	+27 lines, -20 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

jvoung - send to chromium...

Question: Are there incompatibilities between pnacl-gcc and pnacl-clang too? Otherwise, the changes LGTM

9 years, 2 months ago (2011-10-21 00:06:12 UTC) #2

So far, there have been no incompatibilities.

Expand Messages | Collapse Messages