Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(47)

Issue 8366015: Merge 97907 - Multiple crashes in RenderTable during layout (Closed)

Created:
9 years, 2 months ago by Julien - ping for review
Modified:
9 years, 2 months ago
Reviewers:
jchaffraix
CC:
chromium-reviews
Base URL:
http://svn.webkit.org/repository/webkit/branches/chromium/912/
Visibility:
Public.

Description

Merge 97907 - Multiple crashes in RenderTable during layout https://bugs.webkit.org/show_bug.cgi?id=70392 Reviewed by Simon Fraser. Source/WebCore: Tests: fast/table/crash-anonymous-table-computeLogicalWidth.html fast/table/crash-anonymous-table-layout.html r97555 forgot to take into account anonymous tables during layout where RenderObject::node() is NULL. * rendering/RenderTable.cpp: (WebCore::RenderTable::computeLogicalWidth): (WebCore::RenderTable::layout): Added a check for node() before calling Node::hasTagName. LayoutTests: * fast/table/crash-anonymous-table-computeLogicalWidth-expected.txt: Added. * fast/table/crash-anonymous-table-computeLogicalWidth.html: Added. * fast/table/crash-anonymous-table-layout-expected.txt: Added. * fast/table/crash-anonymous-table-layout.html: Added. TBR=jchaffraix@webkit.org Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=98019

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+-2 lines, --2 lines) Patch
A + LayoutTests/fast/table/crash-anonymous-table-computeLogicalWidth.html View 0 chunks +-1 lines, --1 lines 0 comments Download
A + LayoutTests/fast/table/crash-anonymous-table-computeLogicalWidth-expected.txt View 0 chunks +-1 lines, --1 lines 0 comments Download
A + LayoutTests/fast/table/crash-anonymous-table-layout.html View 0 chunks +-1 lines, --1 lines 0 comments Download
A + LayoutTests/fast/table/crash-anonymous-table-layout-expected.txt View 0 chunks +-1 lines, --1 lines 0 comments Download
M Source/WebCore/rendering/RenderTable.cpp View 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 1 (0 generated)
Julien - ping for review
9 years, 2 months ago (2011-10-20 20:25:45 UTC) #1

          

Powered by Google App Engine
This is Rietveld 408576698