runtime/vm/intrinsifier_x64.cc - Issue 836593002: Deletion barrier: Distinguish+verify field initialization in ia32 generated code.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: runtime/vm/intrinsifier_x64.cc

Issue 836593002: Deletion barrier: Distinguish+verify field initialization in ia32 generated code. (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Patch Set: Created 5 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: runtime/vm/intrinsifier_x64.cc

===================================================================

--- runtime/vm/intrinsifier_x64.cc (revision 42713)

+++ runtime/vm/intrinsifier_x64.cc (working copy)

@@ -90,7 +90,7 @@

RCX);

// Set the length field in the growable array object to 0.

- __ ZeroSmiField(FieldAddress(RAX, GrowableObjectArray::length_offset()));

+ __ ZeroInitSmiField(FieldAddress(RAX, GrowableObjectArray::length_offset()));

__ ret(); // returns the newly allocated object in RAX.

__ Bind(&fall_through);

@@ -1782,7 +1782,7 @@

FieldAddress(RAX, String::length_offset()),

RDI);

// Clear hash.

- __ ZeroSmiField(FieldAddress(RAX, String::hash_offset()));

+ __ ZeroInitSmiField(FieldAddress(RAX, String::hash_offset()));

__ jmp(ok, Assembler::kNearJump);

__ Bind(&pop_and_fail);

« no previous file with comments | « runtime/vm/intrinsifier_ia32.cc ('k') | runtime/vm/scavenger.h » ('j') | no next file with comments »