Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(695)

Side by Side Diff: runtime/vm/intermediate_language_mips.cc

Issue 836593002: Deletion barrier: Distinguish+verify field initialization in ia32 generated code. (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/
Patch Set: Created 5 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « runtime/vm/intermediate_language_ia32.cc ('k') | runtime/vm/intermediate_language_x64.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2013, the Dart project authors. Please see the AUTHORS file 1 // Copyright (c) 2013, the Dart project authors. Please see the AUTHORS file
2 // for details. All rights reserved. Use of this source code is governed by a 2 // for details. All rights reserved. Use of this source code is governed by a
3 // BSD-style license that can be found in the LICENSE file. 3 // BSD-style license that can be found in the LICENSE file.
4 4
5 #include "vm/globals.h" // Needed here to get TARGET_ARCH_MIPS. 5 #include "vm/globals.h" // Needed here to get TARGET_ARCH_MIPS.
6 #if defined(TARGET_ARCH_MIPS) 6 #if defined(TARGET_ARCH_MIPS)
7 7
8 #include "vm/intermediate_language.h" 8 #include "vm/intermediate_language.h"
9 9
10 #include "vm/dart_entry.h" 10 #include "vm/dart_entry.h"
(...skipping 1898 matching lines...) Expand 10 before | Expand all | Expand 10 after
1909 1909
1910 1910
1911 LocationSummary* StoreInstanceFieldInstr::MakeLocationSummary(Isolate* isolate, 1911 LocationSummary* StoreInstanceFieldInstr::MakeLocationSummary(Isolate* isolate,
1912 bool opt) const { 1912 bool opt) const {
1913 const intptr_t kNumInputs = 2; 1913 const intptr_t kNumInputs = 2;
1914 const intptr_t kNumTemps = 1914 const intptr_t kNumTemps =
1915 (IsUnboxedStore() && opt) ? 2 : 1915 (IsUnboxedStore() && opt) ? 2 :
1916 ((IsPotentialUnboxedStore()) ? 3 : 0); 1916 ((IsPotentialUnboxedStore()) ? 3 : 0);
1917 LocationSummary* summary = new(isolate) LocationSummary( 1917 LocationSummary* summary = new(isolate) LocationSummary(
1918 isolate, kNumInputs, kNumTemps, 1918 isolate, kNumInputs, kNumTemps,
1919 ((IsUnboxedStore() && opt && is_initialization_) || 1919 ((IsUnboxedStore() && opt && is_potential_unboxed_initialization_) ||
1920 IsPotentialUnboxedStore()) 1920 IsPotentialUnboxedStore())
1921 ? LocationSummary::kCallOnSlowPath 1921 ? LocationSummary::kCallOnSlowPath
1922 : LocationSummary::kNoCall); 1922 : LocationSummary::kNoCall);
1923 1923
1924 summary->set_in(0, Location::RequiresRegister()); 1924 summary->set_in(0, Location::RequiresRegister());
1925 if (IsUnboxedStore() && opt) { 1925 if (IsUnboxedStore() && opt) {
1926 summary->set_in(1, Location::RequiresFpuRegister()); 1926 summary->set_in(1, Location::RequiresFpuRegister());
1927 summary->set_temp(0, Location::RequiresRegister()); 1927 summary->set_temp(0, Location::RequiresRegister());
1928 summary->set_temp(1, Location::RequiresRegister()); 1928 summary->set_temp(1, Location::RequiresRegister());
1929 } else if (IsPotentialUnboxedStore()) { 1929 } else if (IsPotentialUnboxedStore()) {
(...skipping 34 matching lines...) Expand 10 before | Expand all | Expand 10 after
1964 Label skip_store; 1964 Label skip_store;
1965 1965
1966 Register instance_reg = locs()->in(0).reg(); 1966 Register instance_reg = locs()->in(0).reg();
1967 1967
1968 if (IsUnboxedStore() && compiler->is_optimizing()) { 1968 if (IsUnboxedStore() && compiler->is_optimizing()) {
1969 DRegister value = locs()->in(1).fpu_reg(); 1969 DRegister value = locs()->in(1).fpu_reg();
1970 Register temp = locs()->temp(0).reg(); 1970 Register temp = locs()->temp(0).reg();
1971 Register temp2 = locs()->temp(1).reg(); 1971 Register temp2 = locs()->temp(1).reg();
1972 const intptr_t cid = field().UnboxedFieldCid(); 1972 const intptr_t cid = field().UnboxedFieldCid();
1973 1973
1974 if (is_initialization_) { 1974 if (is_potential_unboxed_initialization_) {
1975 const Class* cls = NULL; 1975 const Class* cls = NULL;
1976 switch (cid) { 1976 switch (cid) {
1977 case kDoubleCid: 1977 case kDoubleCid:
1978 cls = &compiler->double_class(); 1978 cls = &compiler->double_class();
1979 break; 1979 break;
1980 default: 1980 default:
1981 UNREACHABLE(); 1981 UNREACHABLE();
1982 } 1982 }
1983 1983
1984 BoxAllocationSlowPath::Allocate(compiler, this, *cls, temp, temp2); 1984 BoxAllocationSlowPath::Allocate(compiler, this, *cls, temp, temp2);
(...skipping 3599 matching lines...) Expand 10 before | Expand all | Expand 10 after
5584 compiler->GenerateCall(token_pos(), &label, stub_kind_, locs()); 5584 compiler->GenerateCall(token_pos(), &label, stub_kind_, locs());
5585 #if defined(DEBUG) 5585 #if defined(DEBUG)
5586 __ LoadImmediate(S4, kInvalidObjectPointer); 5586 __ LoadImmediate(S4, kInvalidObjectPointer);
5587 __ LoadImmediate(S5, kInvalidObjectPointer); 5587 __ LoadImmediate(S5, kInvalidObjectPointer);
5588 #endif 5588 #endif
5589 } 5589 }
5590 5590
5591 } // namespace dart 5591 } // namespace dart
5592 5592
5593 #endif // defined TARGET_ARCH_MIPS 5593 #endif // defined TARGET_ARCH_MIPS
OLDNEW
« no previous file with comments | « runtime/vm/intermediate_language_ia32.cc ('k') | runtime/vm/intermediate_language_x64.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698