Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1675)

Side by Side Diff: runtime/vm/intermediate_language_arm64.cc

Issue 836593002: Deletion barrier: Distinguish+verify field initialization in ia32 generated code. (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/
Patch Set: Created 5 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « runtime/vm/intermediate_language_arm.cc ('k') | runtime/vm/intermediate_language_ia32.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2014, the Dart project authors. Please see the AUTHORS file 1 // Copyright (c) 2014, the Dart project authors. Please see the AUTHORS file
2 // for details. All rights reserved. Use of this source code is governed by a 2 // for details. All rights reserved. Use of this source code is governed by a
3 // BSD-style license that can be found in the LICENSE file. 3 // BSD-style license that can be found in the LICENSE file.
4 4
5 #include "vm/globals.h" // Needed here to get TARGET_ARCH_ARM64. 5 #include "vm/globals.h" // Needed here to get TARGET_ARCH_ARM64.
6 #if defined(TARGET_ARCH_ARM64) 6 #if defined(TARGET_ARCH_ARM64)
7 7
8 #include "vm/intermediate_language.h" 8 #include "vm/intermediate_language.h"
9 9
10 #include "vm/dart_entry.h" 10 #include "vm/dart_entry.h"
(...skipping 1735 matching lines...) Expand 10 before | Expand all | Expand 10 after
1746 1746
1747 1747
1748 LocationSummary* StoreInstanceFieldInstr::MakeLocationSummary(Isolate* isolate, 1748 LocationSummary* StoreInstanceFieldInstr::MakeLocationSummary(Isolate* isolate,
1749 bool opt) const { 1749 bool opt) const {
1750 const intptr_t kNumInputs = 2; 1750 const intptr_t kNumInputs = 2;
1751 const intptr_t kNumTemps = 1751 const intptr_t kNumTemps =
1752 (IsUnboxedStore() && opt) ? 2 : 1752 (IsUnboxedStore() && opt) ? 2 :
1753 ((IsPotentialUnboxedStore()) ? 2 : 0); 1753 ((IsPotentialUnboxedStore()) ? 2 : 0);
1754 LocationSummary* summary = new(isolate) LocationSummary( 1754 LocationSummary* summary = new(isolate) LocationSummary(
1755 isolate, kNumInputs, kNumTemps, 1755 isolate, kNumInputs, kNumTemps,
1756 ((IsUnboxedStore() && opt && is_initialization_) || 1756 ((IsUnboxedStore() && opt && is_potential_unboxed_initialization_) ||
1757 IsPotentialUnboxedStore()) 1757 IsPotentialUnboxedStore())
1758 ? LocationSummary::kCallOnSlowPath 1758 ? LocationSummary::kCallOnSlowPath
1759 : LocationSummary::kNoCall); 1759 : LocationSummary::kNoCall);
1760 1760
1761 summary->set_in(0, Location::RequiresRegister()); 1761 summary->set_in(0, Location::RequiresRegister());
1762 if (IsUnboxedStore() && opt) { 1762 if (IsUnboxedStore() && opt) {
1763 summary->set_in(1, Location::RequiresFpuRegister()); 1763 summary->set_in(1, Location::RequiresFpuRegister());
1764 summary->set_temp(0, Location::RequiresRegister()); 1764 summary->set_temp(0, Location::RequiresRegister());
1765 summary->set_temp(1, Location::RequiresRegister()); 1765 summary->set_temp(1, Location::RequiresRegister());
1766 } else if (IsPotentialUnboxedStore()) { 1766 } else if (IsPotentialUnboxedStore()) {
(...skipping 15 matching lines...) Expand all
1782 Label skip_store; 1782 Label skip_store;
1783 1783
1784 const Register instance_reg = locs()->in(0).reg(); 1784 const Register instance_reg = locs()->in(0).reg();
1785 1785
1786 if (IsUnboxedStore() && compiler->is_optimizing()) { 1786 if (IsUnboxedStore() && compiler->is_optimizing()) {
1787 const VRegister value = locs()->in(1).fpu_reg(); 1787 const VRegister value = locs()->in(1).fpu_reg();
1788 const Register temp = locs()->temp(0).reg(); 1788 const Register temp = locs()->temp(0).reg();
1789 const Register temp2 = locs()->temp(1).reg(); 1789 const Register temp2 = locs()->temp(1).reg();
1790 const intptr_t cid = field().UnboxedFieldCid(); 1790 const intptr_t cid = field().UnboxedFieldCid();
1791 1791
1792 if (is_initialization_) { 1792 if (is_potential_unboxed_initialization_) {
1793 const Class* cls = NULL; 1793 const Class* cls = NULL;
1794 switch (cid) { 1794 switch (cid) {
1795 case kDoubleCid: 1795 case kDoubleCid:
1796 cls = &compiler->double_class(); 1796 cls = &compiler->double_class();
1797 break; 1797 break;
1798 case kFloat32x4Cid: 1798 case kFloat32x4Cid:
1799 cls = &compiler->float32x4_class(); 1799 cls = &compiler->float32x4_class();
1800 break; 1800 break;
1801 case kFloat64x2Cid: 1801 case kFloat64x2Cid:
1802 cls = &compiler->float64x2_class(); 1802 cls = &compiler->float64x2_class();
(...skipping 3801 matching lines...) Expand 10 before | Expand all | Expand 10 after
5604 compiler->GenerateCall(token_pos(), &label, stub_kind_, locs()); 5604 compiler->GenerateCall(token_pos(), &label, stub_kind_, locs());
5605 #if defined(DEBUG) 5605 #if defined(DEBUG)
5606 __ LoadImmediate(R4, kInvalidObjectPointer, kNoPP); 5606 __ LoadImmediate(R4, kInvalidObjectPointer, kNoPP);
5607 __ LoadImmediate(R5, kInvalidObjectPointer, kNoPP); 5607 __ LoadImmediate(R5, kInvalidObjectPointer, kNoPP);
5608 #endif 5608 #endif
5609 } 5609 }
5610 5610
5611 } // namespace dart 5611 } // namespace dart
5612 5612
5613 #endif // defined TARGET_ARCH_ARM64 5613 #endif // defined TARGET_ARCH_ARM64
OLDNEW
« no previous file with comments | « runtime/vm/intermediate_language_arm.cc ('k') | runtime/vm/intermediate_language_ia32.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698