Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(947)

Side by Side Diff: runtime/vm/intermediate_language_arm.cc

Issue 836593002: Deletion barrier: Distinguish+verify field initialization in ia32 generated code. (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/
Patch Set: Created 5 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « runtime/vm/intermediate_language.h ('k') | runtime/vm/intermediate_language_arm64.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2013, the Dart project authors. Please see the AUTHORS file 1 // Copyright (c) 2013, the Dart project authors. Please see the AUTHORS file
2 // for details. All rights reserved. Use of this source code is governed by a 2 // for details. All rights reserved. Use of this source code is governed by a
3 // BSD-style license that can be found in the LICENSE file. 3 // BSD-style license that can be found in the LICENSE file.
4 4
5 #include "vm/globals.h" // Needed here to get TARGET_ARCH_ARM. 5 #include "vm/globals.h" // Needed here to get TARGET_ARCH_ARM.
6 #if defined(TARGET_ARCH_ARM) 6 #if defined(TARGET_ARCH_ARM)
7 7
8 #include "vm/intermediate_language.h" 8 #include "vm/intermediate_language.h"
9 9
10 #include "vm/cpu.h" 10 #include "vm/cpu.h"
(...skipping 1975 matching lines...) Expand 10 before | Expand all | Expand 10 after
1986 1986
1987 1987
1988 LocationSummary* StoreInstanceFieldInstr::MakeLocationSummary(Isolate* isolate, 1988 LocationSummary* StoreInstanceFieldInstr::MakeLocationSummary(Isolate* isolate,
1989 bool opt) const { 1989 bool opt) const {
1990 const intptr_t kNumInputs = 2; 1990 const intptr_t kNumInputs = 2;
1991 const intptr_t kNumTemps = 1991 const intptr_t kNumTemps =
1992 (IsUnboxedStore() && opt) ? 2 : 1992 (IsUnboxedStore() && opt) ? 2 :
1993 ((IsPotentialUnboxedStore()) ? 3 : 0); 1993 ((IsPotentialUnboxedStore()) ? 3 : 0);
1994 LocationSummary* summary = new(isolate) LocationSummary( 1994 LocationSummary* summary = new(isolate) LocationSummary(
1995 isolate, kNumInputs, kNumTemps, 1995 isolate, kNumInputs, kNumTemps,
1996 ((IsUnboxedStore() && opt && is_initialization_) || 1996 ((IsUnboxedStore() && opt && is_potential_unboxed_initialization_) ||
1997 IsPotentialUnboxedStore()) 1997 IsPotentialUnboxedStore())
1998 ? LocationSummary::kCallOnSlowPath 1998 ? LocationSummary::kCallOnSlowPath
1999 : LocationSummary::kNoCall); 1999 : LocationSummary::kNoCall);
2000 2000
2001 summary->set_in(0, Location::RequiresRegister()); 2001 summary->set_in(0, Location::RequiresRegister());
2002 if (IsUnboxedStore() && opt) { 2002 if (IsUnboxedStore() && opt) {
2003 summary->set_in(1, Location::RequiresFpuRegister()); 2003 summary->set_in(1, Location::RequiresFpuRegister());
2004 summary->set_temp(0, Location::RequiresRegister()); 2004 summary->set_temp(0, Location::RequiresRegister());
2005 summary->set_temp(1, Location::RequiresRegister()); 2005 summary->set_temp(1, Location::RequiresRegister());
2006 } else if (IsPotentialUnboxedStore()) { 2006 } else if (IsPotentialUnboxedStore()) {
(...skipping 39 matching lines...) Expand 10 before | Expand all | Expand 10 after
2046 Label skip_store; 2046 Label skip_store;
2047 2047
2048 const Register instance_reg = locs()->in(0).reg(); 2048 const Register instance_reg = locs()->in(0).reg();
2049 2049
2050 if (IsUnboxedStore() && compiler->is_optimizing()) { 2050 if (IsUnboxedStore() && compiler->is_optimizing()) {
2051 const DRegister value = EvenDRegisterOf(locs()->in(1).fpu_reg()); 2051 const DRegister value = EvenDRegisterOf(locs()->in(1).fpu_reg());
2052 const Register temp = locs()->temp(0).reg(); 2052 const Register temp = locs()->temp(0).reg();
2053 const Register temp2 = locs()->temp(1).reg(); 2053 const Register temp2 = locs()->temp(1).reg();
2054 const intptr_t cid = field().UnboxedFieldCid(); 2054 const intptr_t cid = field().UnboxedFieldCid();
2055 2055
2056 if (is_initialization_) { 2056 if (is_potential_unboxed_initialization_) {
2057 const Class* cls = NULL; 2057 const Class* cls = NULL;
2058 switch (cid) { 2058 switch (cid) {
2059 case kDoubleCid: 2059 case kDoubleCid:
2060 cls = &compiler->double_class(); 2060 cls = &compiler->double_class();
2061 break; 2061 break;
2062 case kFloat32x4Cid: 2062 case kFloat32x4Cid:
2063 cls = &compiler->float32x4_class(); 2063 cls = &compiler->float32x4_class();
2064 break; 2064 break;
2065 case kFloat64x2Cid: 2065 case kFloat64x2Cid:
2066 cls = &compiler->float64x2_class(); 2066 cls = &compiler->float64x2_class();
(...skipping 4859 matching lines...) Expand 10 before | Expand all | Expand 10 after
6926 compiler->GenerateCall(token_pos(), &label, stub_kind_, locs()); 6926 compiler->GenerateCall(token_pos(), &label, stub_kind_, locs());
6927 #if defined(DEBUG) 6927 #if defined(DEBUG)
6928 __ LoadImmediate(R4, kInvalidObjectPointer); 6928 __ LoadImmediate(R4, kInvalidObjectPointer);
6929 __ LoadImmediate(R5, kInvalidObjectPointer); 6929 __ LoadImmediate(R5, kInvalidObjectPointer);
6930 #endif 6930 #endif
6931 } 6931 }
6932 6932
6933 } // namespace dart 6933 } // namespace dart
6934 6934
6935 #endif // defined TARGET_ARCH_ARM 6935 #endif // defined TARGET_ARCH_ARM
OLDNEW
« no previous file with comments | « runtime/vm/intermediate_language.h ('k') | runtime/vm/intermediate_language_arm64.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698