Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(811)

Side by Side Diff: runtime/vm/flow_graph_builder.cc

Issue 836593002: Deletion barrier: Distinguish+verify field initialization in ia32 generated code. (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/
Patch Set: Created 5 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « runtime/vm/disassembler_ia32.cc ('k') | runtime/vm/flow_graph_compiler_ia32.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2012, the Dart project authors. Please see the AUTHORS file 1 // Copyright (c) 2012, the Dart project authors. Please see the AUTHORS file
2 // for details. All rights reserved. Use of this source code is governed by a 2 // for details. All rights reserved. Use of this source code is governed by a
3 // BSD-style license that can be found in the LICENSE file. 3 // BSD-style license that can be found in the LICENSE file.
4 4
5 #include "vm/flow_graph_builder.h" 5 #include "vm/flow_graph_builder.h"
6 6
7 #include "lib/invocation_mirror.h" 7 #include "lib/invocation_mirror.h"
8 #include "vm/ast_printer.h" 8 #include "vm/ast_printer.h"
9 #include "vm/bit_vector.h" 9 #include "vm/bit_vector.h"
10 #include "vm/class_finalizer.h" 10 #include "vm/class_finalizer.h"
(...skipping 3474 matching lines...) Expand 10 before | Expand all | Expand 10 after
3485 I->GetNextDeoptId()); 3485 I->GetNextDeoptId());
3486 AddInstruction(guard_field_length); 3486 AddInstruction(guard_field_length);
3487 3487
3488 store_value = Bind(BuildLoadExprTemp()); 3488 store_value = Bind(BuildLoadExprTemp());
3489 StoreInstanceFieldInstr* store = 3489 StoreInstanceFieldInstr* store =
3490 new(I) StoreInstanceFieldInstr(node->field(), 3490 new(I) StoreInstanceFieldInstr(node->field(),
3491 for_instance.value(), 3491 for_instance.value(),
3492 store_value, 3492 store_value,
3493 kEmitStoreBarrier, 3493 kEmitStoreBarrier,
3494 node->token_pos()); 3494 node->token_pos());
3495 store->set_is_initialization(true); // Maybe initializing store. 3495 // Maybe initializing unboxed store.
3496 store->set_is_potential_unboxed_initialization(true);
3496 ReturnDefinition(store); 3497 ReturnDefinition(store);
3497 } 3498 }
3498 3499
3499 3500
3500 void EffectGraphVisitor::VisitLoadStaticFieldNode(LoadStaticFieldNode* node) { 3501 void EffectGraphVisitor::VisitLoadStaticFieldNode(LoadStaticFieldNode* node) {
3501 if (node->field().is_const()) { 3502 if (node->field().is_const()) {
3502 ASSERT(node->field().value() != Object::sentinel().raw()); 3503 ASSERT(node->field().value() != Object::sentinel().raw());
3503 ASSERT(node->field().value() != Object::transition_sentinel().raw()); 3504 ASSERT(node->field().value() != Object::transition_sentinel().raw());
3504 Definition* result = 3505 Definition* result =
3505 new(I) ConstantInstr(Instance::ZoneHandle(I, node->field().value())); 3506 new(I) ConstantInstr(Instance::ZoneHandle(I, node->field().value()));
(...skipping 808 matching lines...) Expand 10 before | Expand all | Expand 10 after
4314 Report::MessageF(Report::kBailout, 4315 Report::MessageF(Report::kBailout,
4315 Script::Handle(function.script()), 4316 Script::Handle(function.script()),
4316 function.token_pos(), 4317 function.token_pos(),
4317 "FlowGraphBuilder Bailout: %s %s", 4318 "FlowGraphBuilder Bailout: %s %s",
4318 String::Handle(function.name()).ToCString(), 4319 String::Handle(function.name()).ToCString(),
4319 reason); 4320 reason);
4320 UNREACHABLE(); 4321 UNREACHABLE();
4321 } 4322 }
4322 4323
4323 } // namespace dart 4324 } // namespace dart
OLDNEW
« no previous file with comments | « runtime/vm/disassembler_ia32.cc ('k') | runtime/vm/flow_graph_compiler_ia32.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698