components/data_reduction_proxy/core/common/data_reduction_proxy_params.h - Issue 836583002: Add support for field trial group to relax missing via header bypass logic.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/data_reduction_proxy/core/common/data_reduction_proxy_params.h

Issue 836583002: Add support for field trial group to relax missing via header bypass logic. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Removed unused include from aw_url_request_context_getter.cc Created 5 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « components/data_reduction_proxy/core/browser/data_reduction_proxy_protocol_unittest.cc ('k') | components/data_reduction_proxy/core/common/data_reduction_proxy_params.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/data_reduction_proxy/core/common/data_reduction_proxy_params.h

diff --git a/components/data_reduction_proxy/core/common/data_reduction_proxy_params.h b/components/data_reduction_proxy/core/common/data_reduction_proxy_params.h

index cba1871e8c5e9b02f7f0c3e37d6abdaf021ddba6..05f0e5bae3fb2f2b17f3da78bd7e58ed609031c0 100644

--- a/components/data_reduction_proxy/core/common/data_reduction_proxy_params.h

+++ b/components/data_reduction_proxy/core/common/data_reduction_proxy_params.h

@@ -86,6 +86,13 @@ class DataReductionProxyParams {

// the data reduction proxy via header is missing.

static bool IsIncludedInRemoveMissingViaHeaderOtherBypassFieldTrial();

+ // Returns true if this client is part of a field trial that relaxes the

+ // |MISSING_VIA_HEADER_OTHER| proxy bypass case. In this experiment, if a

+ // response with a data reduction proxy via header has been received through

+ // the proxy since the last network change, then don't bypass on missing via

+ // headers in responses with non-4xx response codes.

+ static bool IsIncludedInRelaxMissingViaHeaderOtherBypassFieldTrial();

// Returns true if this client is part of the field trial that should display

// a promotion for the data reduction proxy on Android One devices.

static bool IsIncludedInAndroidOnePromoFieldTrial(