components/data_reduction_proxy/core/browser/data_reduction_proxy_interceptor.cc - Issue 836583002: Add support for field trial group to relax missing via header bypass logic.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/data_reduction_proxy/core/browser/data_reduction_proxy_interceptor.cc

Issue 836583002: Add support for field trial group to relax missing via header bypass logic. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Removed unused include from aw_url_request_context_getter.cc Created 5 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « components/data_reduction_proxy/core/browser/data_reduction_proxy_interceptor.h ('k') | components/data_reduction_proxy/core/browser/data_reduction_proxy_network_delegate.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/data_reduction_proxy/core/browser/data_reduction_proxy_interceptor.cc

diff --git a/components/data_reduction_proxy/core/browser/data_reduction_proxy_interceptor.cc b/components/data_reduction_proxy/core/browser/data_reduction_proxy_interceptor.cc

index 36373a21e1fbb97f78b8370ef17c21c72760d690..028316337aa79755f825a8c6db589f105c283473 100644

--- a/components/data_reduction_proxy/core/browser/data_reduction_proxy_interceptor.cc

+++ b/components/data_reduction_proxy/core/browser/data_reduction_proxy_interceptor.cc

@@ -4,7 +4,7 @@

#include "components/data_reduction_proxy/core/browser/data_reduction_proxy_interceptor.h"

-#include "components/data_reduction_proxy/core/browser/data_reduction_proxy_protocol.h"

+#include "components/data_reduction_proxy/core/browser/data_reduction_proxy_bypass_protocol.h"

#include "components/data_reduction_proxy/core/browser/data_reduction_proxy_usage_stats.h"

#include "components/data_reduction_proxy/core/common/data_reduction_proxy_headers.h"

#include "components/data_reduction_proxy/core/common/data_reduction_proxy_params.h"

@@ -23,8 +23,9 @@ DataReductionProxyInterceptor::DataReductionProxyInterceptor(

DataReductionProxyEventStore* event_store)

: params_(params),

usage_stats_(stats),

- event_store_(event_store) {

+ event_store_(event_store),

+ bypass_protocol_(

+ new DataReductionProxyBypassProtocol(params, event_store)) {}

DataReductionProxyInterceptor::~DataReductionProxyInterceptor() {

}

@@ -41,8 +42,8 @@ net::URLRequestJob* DataReductionProxyInterceptor::MaybeInterceptResponse(

if (request->response_info().was_cached)

return nullptr;

DataReductionProxyBypassType bypass_type = BYPASS_EVENT_TYPE_MAX;

- bool should_retry = data_reduction_proxy::MaybeBypassProxyAndPrepareToRetry(

- params_, request, &bypass_type, event_store_);

+ bool should_retry = bypass_protocol_->MaybeBypassProxyAndPrepareToRetry(

+ request, &bypass_type);

if (usage_stats_ && bypass_type != BYPASS_EVENT_TYPE_MAX)

usage_stats_->SetBypassType(bypass_type);

if (!should_retry)