Issue 836413005: Make sure that the TimerEventScope is destroyed before we signal completion

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 836413005: Make sure that the TimerEventScope is destroyed before we signal completion (Closed)

Created:
5 years, 11 months ago by jochen (gone - plz use gerrit)

Modified:
5 years, 11 months ago

Reviewers:
Yang

CC:
v8-dev

Base URL:
https://chromium.googlesource.com/v8/v8.git@master

Target Ref:
refs/pending/heads/master

Project:
v8

Visibility:
Public.

Make sure that the TimerEventScope is destroyed before we signal completion Otherwise, the isolate that is referenced by the scope might already be gone BUG=v8:3608 R=yangguo@chromium.org LOG=n Committed: https://crrev.com/a443998ed3abf5747ca43df297de936d1d67c232 Cr-Commit-Position: refs/heads/master@{#25993}

Created: 5 years, 11 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+16 lines, -13 lines)			Patch
	M	src/optimizing-compiler-thread.cc	View	1	1 chunk	+16 lines, -13 lines	0 comments	Download

Total messages: 6 (1 generated)

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/836413005/20001

5 years, 11 months ago (2015-01-08 12:46:30 UTC) #4

commit-bot: I haz the power

5 years, 11 months ago (2015-01-08 13:14:40 UTC) #6

Message was sent while issue was closed.

Patchset 2 (id:??) landed as
https://crrev.com/a443998ed3abf5747ca43df297de936d1d67c232
Cr-Commit-Position: refs/heads/master@{#25993}