Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(333)

Side by Side Diff: build/win_is_xtree_patched.py

Issue 836393002: Fix xtree patch check, and in turn C4702 disabling (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: fix warning in networking_private_verify_delegate_factory_impl.cc Created 5 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | chrome/browser/extensions/api/networking_private/networking_private_verify_delegate_factory_impl.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 #!/usr/bin/env python 1 #!/usr/bin/env python
2 # Copyright 2014 The Chromium Authors. All rights reserved. 2 # Copyright 2014 The Chromium Authors. All rights reserved.
3 # Use of this source code is governed by a BSD-style license that can be 3 # Use of this source code is governed by a BSD-style license that can be
4 # found in the LICENSE file. 4 # found in the LICENSE file.
5 5
6 """Determines if the VS xtree header has been patched to disable C4702.""" 6 """Determines if the VS xtree header has been patched to disable C4702."""
7 7
8 import os 8 import os
9 9
10 10
11 def IsPatched(): 11 def IsPatched():
12 # TODO(scottmg): For now, just return if we're using the packaged toolchain 12 # TODO(scottmg): For now, just return if we're using the packaged toolchain
13 # script (because we know it's patched). Another case could be added here to 13 # script (because we know it's patched). Another case could be added here to
14 # query the active VS installation and actually check the contents of xtree. 14 # query the active VS installation and actually check the contents of xtree.
15 # http://crbug.com/346399. 15 # http://crbug.com/346399.
16 return os.environ.get('DEPOT_TOOLS_WIN_TOOLCHAIN', 1) == 0 16 return int(os.environ.get('DEPOT_TOOLS_WIN_TOOLCHAIN', 1)) == 1
17 17
18 18
19 def DoMain(_): 19 def DoMain(_):
20 """Hook to be called from gyp without starting a separate python 20 """Hook to be called from gyp without starting a separate python
21 interpreter.""" 21 interpreter."""
22 return IsPatched() 22 return "1" if IsPatched() else "0"
23 23
24 24
25 if __name__ == '__main__': 25 if __name__ == '__main__':
26 print DoMain([]) 26 print DoMain([])
OLDNEW
« no previous file with comments | « no previous file | chrome/browser/extensions/api/networking_private/networking_private_verify_delegate_factory_impl.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698