Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(40)

Issue 836393002: Fix xtree patch check, and in turn C4702 disabling (Closed)

Created:
5 years, 11 months ago by scottmg
Modified:
5 years, 11 months ago
Reviewers:
cpu_(ooo_6.6-7.5)
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix xtree patch check, and in turn C4702 disabling Two bugs: - IsPatched was backwards - The output was "True"/"False", but .gyp was expecting "1"/"0". R=cpu@chromium.org BUG=346399 Committed: https://crrev.com/04dd0973fcc16a1839bf1a57ad9392857844ad52 Cr-Commit-Position: refs/heads/master@{#310409}

Patch Set 1 #

Patch Set 2 : fix warning in networking_private_verify_delegate_factory_impl.cc #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -3 lines) Patch
M build/win_is_xtree_patched.py View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/extensions/api/networking_private/networking_private_verify_delegate_factory_impl.cc View 1 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 8 (2 generated)
cpu_(ooo_6.6-7.5)
lgtm
5 years, 11 months ago (2015-01-07 19:31:06 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/836393002/1
5 years, 11 months ago (2015-01-07 19:52:17 UTC) #3
scottmg
added warning fix in good ol' chrome\browser\extensions\api\networking_private\networking_private_verify_delegate_factory_impl.cc
5 years, 11 months ago (2015-01-07 22:04:14 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/836393002/20001
5 years, 11 months ago (2015-01-07 22:05:48 UTC) #6
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 11 months ago (2015-01-07 23:42:22 UTC) #7
commit-bot: I haz the power
5 years, 11 months ago (2015-01-07 23:43:18 UTC) #8
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/04dd0973fcc16a1839bf1a57ad9392857844ad52
Cr-Commit-Position: refs/heads/master@{#310409}

Powered by Google App Engine
This is Rietveld 408576698