Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(553)

Issue 836383005: Don't walk treescopes in updateActiveStyleSheets until the resolver exists. (Closed)

Created:
5 years, 11 months ago by esprehn
Modified:
5 years, 11 months ago
Reviewers:
ojan
CC:
ojan, abarth-chromium, mojo-reviews_chromium.org
Base URL:
git@github.com:domokit/mojo.git@master
Target Ref:
refs/heads/master
Project:
mojo
Visibility:
Public.

Description

Don't walk treescopes in updateActiveStyleSheets until the resolver exists. The update doesn't actually do anything until the resolver is created, just skip the tree walk. This also removes the special case for document from StyleSheetCollection which didn't make any sense. It would cause us to discard the entire resolver whenever the sheets in the document changed which is far more work than is actually needed. We probably are missing some font invalidation code now, but we can add that back later. R=ojan@chromium.org Committed: https://chromium.googlesource.com/external/mojo/+/f9097c9b39eeee2eda1c1eb5832c725a6cd1e442

Patch Set 1 #

Total comments: 3

Patch Set 2 : Remove comments. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+14 lines, -34 lines) Patch
M sky/engine/core/dom/StyleEngine.h View 2 chunks +1 line, -2 lines 0 comments Download
M sky/engine/core/dom/StyleEngine.cpp View 2 chunks +5 lines, -11 lines 0 comments Download
M sky/engine/core/dom/StyleSheetCollection.h View 2 chunks +2 lines, -2 lines 0 comments Download
M sky/engine/core/dom/StyleSheetCollection.cpp View 1 2 chunks +6 lines, -19 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
esprehn
https://codereview.chromium.org/836383005/diff/1/sky/engine/core/dom/StyleEngine.cpp File sky/engine/core/dom/StyleEngine.cpp (left): https://codereview.chromium.org/836383005/diff/1/sky/engine/core/dom/StyleEngine.cpp#oldcode119 sky/engine/core/dom/StyleEngine.cpp:119: clearResolver(); This didn't make sense, if we're not active ...
5 years, 11 months ago (2015-01-10 04:45:51 UTC) #1
ojan
lgtm https://codereview.chromium.org/836383005/diff/1/sky/engine/core/dom/StyleSheetCollection.cpp File sky/engine/core/dom/StyleSheetCollection.cpp (right): https://codereview.chromium.org/836383005/diff/1/sky/engine/core/dom/StyleSheetCollection.cpp#newcode73 sky/engine/core/dom/StyleSheetCollection.cpp:73: // TODO(esprehn): We need to check if the ...
5 years, 11 months ago (2015-01-10 04:50:54 UTC) #2
esprehn
5 years, 11 months ago (2015-01-10 04:52:49 UTC) #3
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as
f9097c9b39eeee2eda1c1eb5832c725a6cd1e442 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698