Issue 836383004: Remove all attribute selectors that are not Set or Exact.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 836383004: Remove all attribute selectors that are not Set or Exact. (Closed)

Created:
5 years, 11 months ago by esprehn

Modified:
5 years, 11 months ago

Reviewers:
ojan

CC:
ojan, abarth-chromium, mojo-reviews_chromium.org

Base URL:
git@github.com:domokit/mojo.git@master

Target Ref:
refs/heads/master

Project:
mojo

Visibility:
Public.

More Reviews

Description

Remove all attribute selectors that are not Set or Exact. Sky doesn't support prefix, suffix, list, contains or other fancy attribute selectors. R=ojan@chromium.org Committed: https://chromium.googlesource.com/external/mojo/+/ec60f4ba125cacfa68bc18941c79c0bd26279a8b

Patch Set 2 : ojan comment. #

Created: 5 years, 11 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+20 lines, -198 lines)			Patch
M	sky/engine/core/css/CSSSelector.h	View		1 chunk	+0 lines, -5 lines	0 comments	Download
M	sky/engine/core/css/CSSSelector.cpp	View		2 chunks	+3 lines, -32 lines	0 comments	Download
M	sky/engine/core/css/SelectorChecker.cpp	View		2 chunks	+10 lines, -98 lines	0 comments	Download
M	sky/engine/core/css/parser/CSSGrammar.y	View		4 chunks	+2 lines, -30 lines	0 comments	Download
M	sky/engine/core/css/parser/CSSTokenizer-in.cpp	View	1	2 chunks	+5 lines, -33 lines	0 comments	Download

Messages

Total messages: 4 (1 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

ojan

lgtm https://codereview.chromium.org/836383004/diff/1/sky/engine/core/css/parser/CSSTokenizer-in.cpp File sky/engine/core/css/parser/CSSTokenizer-in.cpp (right): https://codereview.chromium.org/836383004/diff/1/sky/engine/core/css/parser/CSSTokenizer-in.cpp#newcode1208 sky/engine/core/css/parser/CSSTokenizer-in.cpp:1208: case CharacterDollar: Add a TODO to get rid ...

5 years, 11 months ago (2015-01-10 02:07:39 UTC) #3

esprehn

5 years, 11 months ago (2015-01-10 02:09:52 UTC) #4

Message was sent while issue was closed.

Committed patchset #2 (id:20001) manually as
ec60f4ba125cacfa68bc18941c79c0bd26279a8b (presubmit successful).

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

Issue 836383004: Remove all attribute selectors that are not Set or Exact. (Closed)

Description

Patch Set 1 #

Patch Set 2 : ojan comment. #

Messages