Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(6)

Issue 836373003: Revert of content: Remove switches::kSkipGpuDataLoading from content_shell (Closed)

Created:
5 years, 11 months ago by jsbell
Modified:
5 years, 11 months ago
CC:
chromium-reviews, darin-cc_chromium.org, jam, jochen+watch_chromium.org, mkwst+moarreviews-shell_chromium.org, mlamouri+watch-content_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of content: Remove switches::kSkipGpuDataLoading from content_shell (patchset #1 id:1 of https://codereview.chromium.org/827293002/) Reason for revert: Speculative revert for crashes on WinXP bots. See crbug.com/446834 I will re-land if this does not fix the crashes. Original issue's description: > content: Remove switches::kSkipGpuDataLoading from content_shell > > switches::kSkipGpuDataLoading causes the content_shell to not load > the blacklist and driver bug list. This is preventing another cl > from landing that enables GPU rasterization. > > Note for sherrifs, this flag was introduced to fix flake with > GpuTabTest, if we see this test flaking out, it may be as a > result to this change. > > BUG=445500 > > Committed: https://crrev.com/ace5b877610adc14182677cca9c6b038ea161ccf > Cr-Commit-Position: refs/heads/master@{#310132} TBR=piman@chromium.org,jochen@chromium.org,hendrikw@chromium.org NOTREECHECKS=true NOTRY=true BUG=445500 Committed: https://crrev.com/692532485ca7090bdf404030d22b9306ae3dad3b Cr-Commit-Position: refs/heads/master@{#310400}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -0 lines) Patch
M content/shell/app/shell_main_delegate.cc View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
jsbell
Created Revert of content: Remove switches::kSkipGpuDataLoading from content_shell
5 years, 11 months ago (2015-01-07 22:58:45 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/836373003/1
5 years, 11 months ago (2015-01-07 23:00:05 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 11 months ago (2015-01-07 23:01:03 UTC) #3
commit-bot: I haz the power
5 years, 11 months ago (2015-01-07 23:02:03 UTC) #4
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/692532485ca7090bdf404030d22b9306ae3dad3b
Cr-Commit-Position: refs/heads/master@{#310400}

Powered by Google App Engine
This is Rietveld 408576698