OLD | NEW |
1 Hacking on Sky | 1 Hacking on Sky |
2 ============== | 2 ============== |
3 | 3 |
4 Building | 4 Building |
5 -------- | 5 -------- |
6 | 6 |
7 * Follow the setup & build instructions for [Mojo](https://github.com/domokit/mo
jo) | 7 * Follow the setup & build instructions for [Mojo](https://github.com/domokit/mo
jo) |
8 | 8 |
9 Running applications | 9 Running applications |
10 -------------------- | 10 -------------------- |
(...skipping 23 matching lines...) Expand all Loading... |
34 * Write tests in [mocha format](http://visionmedia.github.io/mocha/#getting-star
ted) and use [chai asserts](http://chaijs.com/api/assert/): | 34 * Write tests in [mocha format](http://visionmedia.github.io/mocha/#getting-star
ted) and use [chai asserts](http://chaijs.com/api/assert/): |
35 ```html | 35 ```html |
36 describe('My pretty test of my subject', function() { | 36 describe('My pretty test of my subject', function() { |
37 var subject = new MySubject(); | 37 var subject = new MySubject(); |
38 | 38 |
39 it('should be pretty', function() { | 39 it('should be pretty', function() { |
40 assert.ok(subject.isPretty); | 40 assert.ok(subject.isPretty); |
41 }); | 41 }); |
42 }); | 42 }); |
43 ``` | 43 ``` |
| 44 |
| 45 Adding pixel tests |
| 46 ------------------ |
| 47 |
| 48 Sky does not have proper pixel tests. Instead we have only reftests. |
| 49 If you want a pixel test, you need to dump the png from a reftest, |
| 50 upload it to googlestorage and then put and <img> pointing to the |
| 51 uploaded file in the reference. |
| 52 |
| 53 1. Create your test (e.g. foo.sky). |
| 54 2. Create an dummy reference file (foo-expected.sky). |
| 55 3. Run the test (it will fail). |
| 56 4. Copy the -actual.png file to googlestorage (see below). |
| 57 5. Put an <img> pointing to your newly uploaded png in the reference file. |
| 58 |
| 59 Copying the file to googlestorage: |
| 60 $ sha1sum ../out/Debug/layout-test-results/framework/flights-app-pixels-actual.p
ng |
| 61 db0508cdfe69e996a93464050dc383f6480f1283 ../out/Debug/layout-test-results/frame
work/flights-app-pixels-actual.png |
| 62 $ gsutil.py cp ../out/Debug/layout-test-results/framework/flights-app-pixels-act
ual.png gs://mojo/sky-pngs/db0508cdfe69e996a93464050dc383f6480f1283 |
| 63 |
| 64 Long-term, we should not have these tests at all and should just |
| 65 dump paint commands. In the short-term, if we find we're doing this |
| 66 a lot we should obviously automate this process, e.g. test_sky could |
| 67 do all of this work, including spitting out the correct reference file. |
OLD | NEW |