Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(92)

Issue 836363003: Make a reftest for the flights app. (Closed)

Created:
5 years, 11 months ago by ojan
Modified:
5 years, 11 months ago
Reviewers:
esprehn
CC:
esprehn, abarth-chromium, mojo-reviews_chromium.org
Base URL:
git@github.com:domokit/mojo.git@master
Target Ref:
refs/heads/master
Project:
mojo
Visibility:
Public.

Description

Make a reftest for the flights app. This way we get some broad pixel test coverage. Do this by dumping the png from the flights app, uploading it to google storage and then having the reference file load the uploaded file. This isn't a good long-term solution. Long-term we should dump paint commands (or some other textual representation) and/or make more targetted reftests that don't need pngs. As such, the process for doing this is painful and manual. If we decide we want to have pixel tests properly, we'll want to do something more automated obviously. Also, turn on the discard_transparency bool when encoding the pngs. Otherwise, the png is lossy and none of this works. R=esprehn@chromium.org Committed: https://chromium.googlesource.com/external/mojo/+/9648321feeba9874fb0e829ba2864855badc7c46

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+42 lines, -2 lines) Patch
M sky/HACKING.md View 1 chunk +24 lines, -0 lines 0 comments Download
M sky/compositor/display_delegate_bitmap.cc View 1 chunk +1 line, -1 line 0 comments Download
A + sky/tests/framework/flights-app-pixels.sky View 1 chunk +4 lines, -1 line 0 comments Download
A sky/tests/framework/flights-app-pixels-expected.sky View 1 chunk +13 lines, -0 lines 0 comments Download

Messages

Total messages: 3 (1 generated)
esprehn
lgtm
5 years, 11 months ago (2015-01-07 19:29:56 UTC) #2
ojan
5 years, 11 months ago (2015-01-07 19:40:32 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
9648321feeba9874fb0e829ba2864855badc7c46 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698