wifi_sync: add WifiConfigDelegate

components/wifi_sync/wifi_config_delegate_chromeos_unittest.cc

+// Copyright 2015 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#include "components/wifi_sync/wifi_config_delegate_chromeos.h"
+
+#include "base/macros.h"
+#include "base/values.h"
+#include "chromeos/network/managed_network_configuration_handler.h"
+#include "components/wifi_sync/wifi_credential.h"
+#include "testing/gtest/include/gtest/gtest.h"
+
+namespace wifi_sync {
+
+namespace {
+const char kSsid[] = "fake-ssid";
+const char kSsidNonUtf8[] = "\xc0";
+const char kUserHash[] = "fake-user-hash";
+}
+
+using chromeos::network_handler::DictionaryResultCallback;

[erikwright (departed), 2015/01/16 14:42:15]

#include chromeos/network/network_handler_callbacks.h

[mukesh agrawal, 2015/01/16 22:45:34]

Done.

+using chromeos::network_handler::ErrorCallback;
+using chromeos::network_handler::StringResultCallback;
+
+class FakeManagedNetworkConfigurationHandler
+    : public chromeos::ManagedNetworkConfigurationHandler {
+ public:
+  FakeManagedNetworkConfigurationHandler()
+      : create_configuration_called_(false) {
+  }
+
+  // ManagedNetworkConfigurationHandler implementation.
+  void AddObserver(chromeos::NetworkPolicyObserver* observer) override {
+    NOTIMPLEMENTED();

[erikwright (departed), 2015/01/16 14:42:15]

#include logging.h

[mukesh agrawal, 2015/01/16 22:45:34]

Done.

+  }
+  void RemoveObserver(chromeos::NetworkPolicyObserver* observer) override {
+    NOTIMPLEMENTED();
+  }
+  void GetProperties(
+      const std::string& service_path,
+      const DictionaryResultCallback& callback,
+      const ErrorCallback& error_callback) override {
+    NOTIMPLEMENTED();
+  }
+  void GetManagedProperties(
+      const std::string& userhash,
+      const std::string& service_path,
+      const DictionaryResultCallback& callback,
+      const ErrorCallback& error_callback) override {
+    NOTIMPLEMENTED();
+  }
+  void SetProperties(
+      const std::string& service_path,
+      const base::DictionaryValue& user_settings,
+      const base::Closure& callback,
+      const ErrorCallback& error_callback) const override {
+    NOTIMPLEMENTED();
+  }
+  void CreateConfiguration(
+      const std::string& userhash,
+      const base::DictionaryValue& properties,
+      const StringResultCallback& callback,
+      const ErrorCallback& error_callback) const override {
+    EXPECT_FALSE(create_configuration_called_);
+    create_configuration_called_ = true;
+    create_configuration_success_callback_ = callback;
+    create_configuration_error_callback_ = error_callback;
+  }
+  void RemoveConfiguration(
+      const std::string& service_path,
+      const base::Closure& callback,
+      const ErrorCallback& error_callback) const override {
+    NOTIMPLEMENTED();
+  }
+  void SetPolicy(
+      ::onc::ONCSource onc_source,
+      const std::string& userhash,
+      const base::ListValue& network_configs_onc,
+      const base::DictionaryValue& global_network_config) override {
+    NOTIMPLEMENTED();
+  }
+  bool IsAnyPolicyApplicationRunning() const override {
+    NOTIMPLEMENTED();
+    return false;
+  }
+  const base::DictionaryValue* FindPolicyByGUID(
+      const std::string userhash,
+      const std::string& guid,
+      ::onc::ONCSource* onc_source) const override {
+    NOTIMPLEMENTED();
+    return nullptr;
+  }
+  const GuidToPolicyMap* GetNetworkConfigsFromPolicy(
+      const std::string& userhash) const override {
+    NOTIMPLEMENTED();
+    return nullptr;
+  }
+  const base::DictionaryValue* GetGlobalConfigFromPolicy(
+      const std::string& userhash) const override {
+    NOTIMPLEMENTED();
+    return nullptr;
+  }
+  const base::DictionaryValue* FindPolicyByGuidAndProfile(
+      const std::string& guid,
+      const std::string& profile_path) const override {
+    NOTIMPLEMENTED();
+    return nullptr;
+  }
+
+  bool create_configuration_called() const {
+    return create_configuration_called_;
+  }
+  const StringResultCallback& create_configuration_success_callback() const {
+    return create_configuration_success_callback_;
+  }
+  const ErrorCallback& create_configuration_error_callback() const {
+    return create_configuration_error_callback_;
+  }
+
+ private:
+  // Whether or not CreateConfiguration has been called on this fake.
+  mutable bool create_configuration_called_;
+  // The last |callback| passed to CreateConfiguration.
+  mutable StringResultCallback create_configuration_success_callback_;
+  // The last |error_callback| passed to CreateConfiguration.
+  mutable ErrorCallback create_configuration_error_callback_;
+};
+
+class WifiConfigDelegateChromeOsTest : public testing::Test {
+ protected:
+  WifiConfigDelegateChromeOsTest()
+      : fake_managed_network_configuration_handler_(
+          new FakeManagedNetworkConfigurationHandler()) {
+    config_delegate_.reset(
+        new WifiConfigDelegateChromeOs(
+            kUserHash,
+            fake_managed_network_configuration_handler_.get()));
+  }
+
+  // Wrapper for WifiConfigDelegateChromeOs::AddToLocalNetworks.
+  void AddToLocalNetworks(const WifiCredential& network_credential) {
+    config_delegate_->AddToLocalNetworks(network_credential);
+  }
+
+  // Returns a new WifiCredential constructed from the given parameters.
+  WifiCredential MakeCredential(const std::string& ssid,
+                                WifiSecurityClass security_class,
+                                const std::string& passphrase) {
+    scoped_ptr<WifiCredential> credential =
+        WifiCredential::Create(
+            WifiCredential::MakeSsidBytesForTest(ssid),
+            security_class,
+            passphrase);
+    CHECK(credential);
+    return *credential;
+  }
+
+  // Runs the last |callback| passed to CreateConfiguration, unless
+  // that |callback| is null.
+  void RunCreateConfigurationSuccessCallback() {
+    const char new_service_path[] = "/service/0";
+    if (!create_configuration_success_callback().is_null()) {

[erikwright (departed), 2015/01/16 14:42:15]

nit: braces not required.

[mukesh agrawal, 2015/01/16 22:45:34]

Done.

+      create_configuration_success_callback().Run(new_service_path);
+    }
+  }
+
+  // Returns whether or not CreateConfiguration has been called
+  // on |fake_managed_network_configuration_handler_|.
+  size_t create_configuration_called() const {
+    return fake_managed_network_configuration_handler_
+        ->create_configuration_called();
+  }
+
+  // Returns the last |callback| passed to the CreateConfiguration
+  // method of |fake_managed_network_configuration_handler_|.
+  const StringResultCallback& create_configuration_success_callback() const {

[erikwright (departed), 2015/01/16 14:42:15]

nit: this accessor is not required since you only invoke it from another member
function. You could inline it.

[mukesh agrawal, 2015/01/16 22:45:34]

Done.

+    return fake_managed_network_configuration_handler_
+        ->create_configuration_success_callback();
+  }
+
+  // Returns the last |error_callback| passed to the CreateConfiguration
+  // method of |fake_managed_network_configuration_handler_|.
+  const ErrorCallback& create_configuration_error_callback() const {
+    return fake_managed_network_configuration_handler_
+        ->create_configuration_error_callback();
+  }
+
+ private:
+  scoped_ptr<WifiConfigDelegateChromeOs> config_delegate_;
+  scoped_ptr<FakeManagedNetworkConfigurationHandler>
+    fake_managed_network_configuration_handler_;
+
+  DISALLOW_COPY_AND_ASSIGN(WifiConfigDelegateChromeOsTest);
+};
+
+TEST_F(WifiConfigDelegateChromeOsTest, AddToLocalNetworksOpen) {
+  AddToLocalNetworks(MakeCredential(kSsid, SECURITY_CLASS_NONE, ""));
+  EXPECT_TRUE(create_configuration_called());

[erikwright (departed), 2015/01/16 14:42:15]

nit: I would make all of these ASSERTs since running the callback doesn't make
sense if they are false.

[mukesh agrawal, 2015/01/16 22:45:34]

Done.

+  RunCreateConfigurationSuccessCallback();
+}
+
+TEST_F(WifiConfigDelegateChromeOsTest, AddToLocalNetworksWep) {
+  AddToLocalNetworks(MakeCredential(kSsid, SECURITY_CLASS_WEP, "abcde"));
+  EXPECT_TRUE(create_configuration_called());
+  RunCreateConfigurationSuccessCallback();
+}
+
+TEST_F(WifiConfigDelegateChromeOsTest, AddToLocalNetworksPsk) {
+  AddToLocalNetworks(
+      MakeCredential(kSsid, SECURITY_CLASS_PSK, "fake-psk-passphrase"));
+  EXPECT_TRUE(create_configuration_called());
+  RunCreateConfigurationSuccessCallback();
+}
+
+TEST_F(WifiConfigDelegateChromeOsTest, AddToLocalNetworksNonUtf8) {
+  AddToLocalNetworks(MakeCredential(kSsidNonUtf8, SECURITY_CLASS_PSK, ""));
+  // TODO(quiche): Change to EXPECT_TRUE, once we support non-UTF-8 SSIDs.
+  EXPECT_FALSE(create_configuration_called());
+  EXPECT_TRUE(create_configuration_success_callback().is_null());

[erikwright (departed), 2015/01/16 14:42:15]

nit: not required. You already verified that the method wasn't called.

[mukesh agrawal, 2015/01/16 22:45:34]

Done.

+}
+
+TEST_F(WifiConfigDelegateChromeOsTest,
+       AddToLocalNetworksCreateConfigurationFailure) {
+  AddToLocalNetworks(MakeCredential(kSsid, SECURITY_CLASS_NONE, ""));
+  EXPECT_TRUE(create_configuration_called());
+  if (!create_configuration_error_callback().is_null()) {
+    create_configuration_error_callback().Run(
+        "Config.CreateConfiguration Failed",
+        make_scoped_ptr(new base::DictionaryValue()));
+  }
+}
+
+}  // namespace wifi_sync