wifi_sync: add WifiConfigDelegate

components/wifi_sync/wifi_config_delegate_chromeos.h

+// Copyright 2015 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#ifndef COMPONENTS_WIFI_SYNC_WIFI_CONFIG_DELEGATE_CHROMEOS_H_
+#define COMPONENTS_WIFI_SYNC_WIFI_CONFIG_DELEGATE_CHROMEOS_H_
+
+#include <string>
+
+#include "base/macros.h"
+#include "components/wifi_sync/wifi_config_delegate.h"
+
+namespace chromeos {
+class ManagedNetworkConfigurationHandler;
+}
+
+namespace wifi_sync {
+
+// ChromeOS-specific implementation of the WifiConfigDelegate interface.
+class WifiConfigDelegateChromeOs : public WifiConfigDelegate {
+ public:
+  // Constructs a delegate, which is responsible for applying changes
+  // to the local network configuration. Any changes made by this
+  // delegate will be applied to the Shill profile that corresponds to
+  // |user_hash|. The caller must ensure that the
+  // |managed_net_config_handler| outlives the delegate.
+  WifiConfigDelegateChromeOs(
+      const std::string& user_hash,
+      chromeos::ManagedNetworkConfigurationHandler* managed_net_config_handler);
+  ~WifiConfigDelegateChromeOs() override;
+
+  // Implementation of WifiConfigDelegate.

[erikwright (departed), 2015/01/13 19:03:13]

// WifiConfigDelegate implementation.

[stevenjb, 2015/01/13 23:45:39]

Or just 'WifiConfigDelegate'. "implementation" is implied.

[erikwright (departed), 2015/01/14 14:51:26]

No. The comment I provided is a convention in Chrome code.

[stevenjb, 2015/01/14 17:08:56]

Opinions vary on this. Chat with pkasting@ for more background. All of the above
are perfectly fine.

[mukesh agrawal, 2015/01/15 03:01:48]

Done.

Went with "BaseClass implenentation." for consistency with
wifi_credential_syncable_service.h.

[erikwright (departed), 2015/01/15 15:12:50]

I'm curious if there is a review thread somewhere you can point me to. If you've
already discussed this with him I don't need to disturb him about it.

[stevenjb, 2015/01/15 16:48:10]

https://groups.google.com/a/chromium.org/forum/#!topic/chromium-dev/Bz8WN-mlS...

Brought up again more recently:
https://groups.google.com/a/chromium.org/forum/#!searchin/chromium-dev/overri...

+  void AddToLocalNetworks(const WifiCredential& network_credential) override;
+
+ private:
+  // The ChromeOS user-hash that should be used when modifying network
+  // configurations.
+  const std::string user_hash_;

[stevenjb, 2015/01/13 23:45:39]

nit: WS between commented members.

[mukesh agrawal, 2015/01/15 03:01:48]

Done.

+  // The object we use to configure ChromeOS network state. See ctor
+  // documentation for details of this object's lifetime.

[erikwright (departed), 2015/01/13 19:03:14]

Remove "See ...". It is self-evident that the lifetime of a raw pointer is not
managed by this class, and presumed unless stated otherwise that it must remain
valid.

[mukesh agrawal, 2015/01/15 03:01:48]

Done.

+  chromeos::ManagedNetworkConfigurationHandler* const
+      managed_network_configuration_handler_;
+
+  DISALLOW_COPY_AND_ASSIGN(WifiConfigDelegateChromeOs);
+};
+
+}  // namespace wifi_sync
+
+#endif  // COMPONENTS_WIFI_SYNC_WIFI_CONFIG_DELEGATE_CHROMEOS_H_