wifi_sync: add WifiConfigDelegate

components/wifi_sync/wifi_config_delegate_chromeos.cc

+// Copyright 2015 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#include "components/wifi_sync/wifi_config_delegate_chromeos.h"
+
+#include "base/bind.h"
+#include "base/logging.h"
+#include "base/memory/scoped_ptr.h"
+#include "base/values.h"
+#include "chromeos/network/managed_network_configuration_handler.h"
+#include "components/wifi_sync/wifi_credential.h"
+
+namespace wifi_sync {
+
+namespace {
+
+void DoNothingWithString(const std::string& arg) {}
+
+void OnCreateConfigurationFailed(
+    const WifiCredential& wifi_credential,
+    const std::string& config_handler_error_message,
+    scoped_ptr<base::DictionaryValue> error_data) {
+  LOG(ERROR) << "Create configuration failed";
+  // TODO(quiche): check if there is a matching network already. If
+  // so, try to configure it with |wifi_credential|.
+}
+
+}  // namespace
+
+WifiConfigDelegateChromeOs::WifiConfigDelegateChromeOs(
+    const std::string& user_hash,
+    chromeos::ManagedNetworkConfigurationHandler* managed_net_config_handler)
+    : user_hash_(user_hash),
+      managed_network_configuration_handler_(managed_net_config_handler) {
+  DCHECK(!user_hash_.empty());
+  DCHECK(managed_network_configuration_handler_);
+}
+
+WifiConfigDelegateChromeOs::~WifiConfigDelegateChromeOs() {
+}
+
+void WifiConfigDelegateChromeOs::AddToLocalNetworks(
+    const WifiCredential& network_credential) {
+  scoped_ptr<base::DictionaryValue> onc_properties(
+      network_credential.ToOncProperties());
+  // TODO(quiche): Replace with DCHECK, once ONC supports non-UTF-8 SSIDs.
+  // crbug.com/432546
+  if (!onc_properties) {
+    LOG(ERROR) << "Failed to generate ONC properties for "
+               << network_credential.ToString();
+    return;
+  }
+  managed_network_configuration_handler_
+      ->CreateConfiguration(
+          user_hash_,
+          *onc_properties,
+          base::Bind(DoNothingWithString),  // success_callback

[erikwright (departed), 2015/01/13 19:03:13]

These appear to be optional, although the documentation doesn't explicitly say
that. If they are optional, I would update the docs to say so, and then, here,
just do "network_handler::StringResultCallback()", which creates a null
callback.

[stevenjb, 2015/01/13 23:45:39]

Correct. We should update the 'Note on callbacks' comment in
network_configuration_handler.h. I will add that some time soon if you don't
want to do that here.

[mukesh agrawal, 2015/01/15 03:01:48]

Working on updating the NetworkConfigurationHandler documentation in
https://codereview.chromium.org/799313004/.

[mukesh agrawal, 2015/01/15 03:01:48]

Done.

+          base::Bind(OnCreateConfigurationFailed, network_credential));
+}
+
+}  // namespace wifi_sync