wifi_sync: add WifiConfigDelegate

components/wifi_sync/wifi_config_delegate.h

+// Copyright 2015 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#ifndef COMPONENTS_WIFI_SYNC_WIFI_CONFIG_DELEGATE_H_
+#define COMPONENTS_WIFI_SYNC_WIFI_CONFIG_DELEGATE_H_
+
+#include "base/macros.h"
+
+namespace wifi_sync {
+
+class WifiCredential;
+
+// Interface for platform-specific delegates, which provide the ability
+// to configure local WiFi networks settings.
+class WifiConfigDelegate {
+ public:
+  WifiConfigDelegate() {}

[stevenjb, 2015/01/13 23:45:39]

No need for constructor in abstract class.

[erikwright (departed), 2015/01/14 14:51:26]

Correct, iff DISALLOW is removed.

[mukesh agrawal, 2015/01/15 03:01:47]

Acknowledged.

[mukesh agrawal, 2015/01/15 03:01:48]

Done.

+  virtual ~WifiConfigDelegate() {}

[stevenjb, 2015/01/13 23:45:39]

This can be protected instead of using DISALLOW...

[erikwright (departed), 2015/01/14 14:51:26]

DISALLOW has nothing to do with the access modifier for the destructor. Making
this protected would prevent (or complicate) the destruction of instances of
this class. I don't think that's intended or desirable here.

As mentioned below, DISALLOW is not required here anyway because of pure-virtual
methods.

Basically, when defining interfaces do not use DISALLOW. Use it on
implementations.

[mukesh agrawal, 2015/01/15 03:01:48]

Acknowledged.

+
+  // Adds a local network configuration entry for a WiFi network using
+  // the properties of |network_credential|. If the entry already
+  // exists, the entry's passphrase is updated.
+  virtual void AddToLocalNetworks(
+      const WifiCredential& network_credential) = 0;
+
+ private:
+  DISALLOW_COPY_AND_ASSIGN(WifiConfigDelegate);

[erikwright (departed), 2015/01/13 19:03:13]

not required (nor the include) because this class is abstract.

[mukesh agrawal, 2015/01/15 03:01:47]

Done.

+};
+
+}  // namespace wifi_sync
+
+#endif  // COMPONENTS_WIFI_SYNC_WIFI_CONFIG_DELEGATE_H_