content/browser/renderer_host/render_sandbox_host_linux.cc - Issue 83633004: Do not spawn a thread in browser/interactive ui tests before spawning sandbox host process

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/renderer_host/render_sandbox_host_linux.cc

Issue 83633004: Do not spawn a thread in browser/interactive ui tests before spawning sandbox host process (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Created 7 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chromeos/dbus/dbus_thread_manager.h ('K') | « chromeos/dbus/dbus_thread_manager.cc ('k') | content/public/test/browser_test_base.cc » ('j') | net/test/embedded_test_server/embedded_test_server.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/browser/renderer_host/render_sandbox_host_linux.cc

diff --git a/content/browser/renderer_host/render_sandbox_host_linux.cc b/content/browser/renderer_host/render_sandbox_host_linux.cc

index b35ac7365b53666510eadfd7e8a1843e94e9d3a0..25cf24c8046575c554d31c902bba5e09c79a21d0 100644

--- a/content/browser/renderer_host/render_sandbox_host_linux.cc

+++ b/content/browser/renderer_host/render_sandbox_host_linux.cc

@@ -709,10 +709,9 @@ void RenderSandboxHostLinux::Init(const std::string& sandbox_path) {

childs_lifeline_fd_ = pipefds[1];

// We need to be monothreaded before we fork().

-#if !defined(TOOLKIT_GTK) && !defined(OS_CHROMEOS)

+#if !defined(TOOLKIT_GTK)

// Exclude gtk port as TestSuite in base/tests/test_suite.cc is calling

// gtk_init.

- // Exclude ChromeOS because KioskTest spawns EmbeddedTestServer.

// TODO(oshima): Remove ifdef when above issues are resolved.

DCHECK_EQ(1, base::GetNumberOfThreads(base::GetCurrentProcessHandle()));

#endif