Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(459)

Unified Diff: net/test/embedded_test_server/embedded_test_server.h

Issue 83633004: Do not spawn a thread in browser/interactive ui tests before spawning sandbox host process (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 7 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: net/test/embedded_test_server/embedded_test_server.h
diff --git a/net/test/embedded_test_server/embedded_test_server.h b/net/test/embedded_test_server/embedded_test_server.h
index d5300b4fe215c160c0df11639e80864bd727e82c..fef4814909b4a5b7f94fd25a7cb6a4866ce560db 100644
--- a/net/test/embedded_test_server/embedded_test_server.h
+++ b/net/test/embedded_test_server/embedded_test_server.h
@@ -39,6 +39,8 @@ class HttpListenSocket : public TCPListenSocket {
virtual void Listen();
private:
+ friend class EmbeddedTestServer;
+ void DetachFromThread();
satorux1 2013/11/26 01:22:58 a function comment is missing.
oshima 2013/11/26 02:18:43 Done.
base::ThreadChecker thread_checker_;
};
@@ -122,6 +124,10 @@ class EmbeddedTestServer : public StreamListenSocket::Delegate {
// on UI thread.
void RegisterRequestHandler(const HandleRequestCallback& callback);
+ // Starts/Stops IO thread that handles http requests.
+ void StartThread();
+ void StopThread();
+
private:
// Initializes and starts the server. If initialization succeeds, Starts()
// will return true.

Powered by Google App Engine
This is Rietveld 408576698