Do not spawn a thread in browser/interactive ui tests before spawning sandbox host process

chrome/browser/chromeos/login/kiosk_browsertest.cc

 // Copyright (c) 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "apps/shell_window.h"
 #include "apps/shell_window_registry.h"
 #include "apps/ui/native_app_window.h"
 #include "ash/desktop_background/desktop_background_controller.h"
 #include "ash/desktop_background/desktop_background_controller_observer.h"
 #include "ash/shell.h"
@@ skipping 231 matching lines @@
   virtual ~KioskTest() {}
 
  protected:
   virtual void SetUp() OVERRIDE {
     base::FilePath test_data_dir;
     PathService::Get(chrome::DIR_TEST_DATA, &test_data_dir);
     embedded_test_server()->ServeFilesFromDirectory(test_data_dir);
     embedded_test_server()->RegisterRequestHandler(
         base::Bind(&FakeGaia::HandleRequest, base::Unretained(&fake_gaia_)));
     ASSERT_TRUE(embedded_test_server()->InitializeAndWaitUntilReady());
+    embedded_test_server()->StopThread();

[satorux1, 2013/11/26 01:22:58]

this is not obvious. could you add some comment about why we need to do this?
why do we need to stop the thread here, and restart in SetUpOnMainThread()?

[oshima, 2013/11/26 02:18:43]

I added comment.

 
     mock_user_manager_.reset(new MockUserManager);
     AppLaunchController::SkipSplashWaitForTesting();
     AppLaunchController::SetNetworkWaitForTesting(kTestNetworkTimeoutSeconds);
 
     InProcessBrowserTest::SetUp();
   }
 
   virtual void SetUpInProcessBrowserTestFixture() OVERRIDE {
     host_resolver()->AddRule("*", "127.0.0.1");
   }
 
+  virtual void SetUpOnMainThread() OVERRIDE {
+    embedded_test_server()->StartThread();
+  }
+
   virtual void CleanUpOnMainThread() OVERRIDE {
     // We need to clean up these objects in this specific order.
     fake_network_notifier_.reset(NULL);
     disable_network_notifier_.reset(NULL);
 
     AppLaunchController::SetNetworkTimeoutCallbackForTesting(NULL);
     AppLaunchSigninScreen::SetUserManagerForTesting(NULL);
 
     // If the login display is still showing, exit gracefully.
     if (LoginDisplayHostImpl::default_host()) {
@@ skipping 692 matching lines @@
   content::WindowedNotificationObserver(
       chrome::NOTIFICATION_KIOSK_AUTOLAUNCH_WARNING_VISIBLE,
       content::NotificationService::AllSources()).Wait();
 
   // Wait for the wallpaper to load.
   WaitForWallpaper();
   EXPECT_TRUE(wallpaper_loaded());
 }
 
 }  // namespace chromeos