Issue 83633002: Experimental parser: continue unifying the API with Scanner.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 83633002: Experimental parser: continue unifying the API with Scanner. (Closed)

Created:
7 years, 1 month ago by marja

Modified:
7 years, 1 month ago

Reviewers:
dcarney

CC:
v8-dev

Base URL:
https://v8.googlecode.com/svn/branches/experimental/parser

Visibility:
Public.

More Reviews

Description

Experimental parser: continue unifying the API with Scanner. This CL adds storing next and current tokens separately and the Location struct. Also, kills additional layer of Next() in lexer-shell, to make it easier to see that the comparsion is fair. TBR=dcarney@chromium.org BUG= Committed: https://code.google.com/p/v8/source/detail?r=18023

Patch Set 1 #

Created: 7 years, 1 month ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+51 lines, -17 lines)			Patch
M	src/lexer/experimental-scanner.h	View	5 chunks	+36 lines, -1 line	0 comments	Download
M	src/lexer/lexer-shell.cc	View	3 chunks	+8 lines, -10 lines	0 comments	Download
M	tools/lexer_generator/code_generator.jinja	View	2 chunks	+7 lines, -6 lines	0 comments	Download

Messages

Total messages: 1 (0 generated)

Expand Messages | Collapse Messages

Message was sent while issue was closed.

Committed patchset #1 manually as r18023.

Expand Messages | Collapse Messages