Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(29)

Unified Diff: chrome/browser/autocomplete/shortcuts_provider_unittest.cc

Issue 836213002: Assume all providers may give zero suggest responses. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Fix compilation issue in athena Created 5 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/autocomplete/shortcuts_provider_unittest.cc
diff --git a/chrome/browser/autocomplete/shortcuts_provider_unittest.cc b/chrome/browser/autocomplete/shortcuts_provider_unittest.cc
index ddd543efc32703d9e4d9e97f18d7d81f4d03e760..e5546bd7a3f76d2591afdc844d637b895e216cb9 100644
--- a/chrome/browser/autocomplete/shortcuts_provider_unittest.cc
+++ b/chrome/browser/autocomplete/shortcuts_provider_unittest.cc
@@ -360,7 +360,7 @@ void ShortcutsProviderTest::RunTest(
metrics::OmniboxEventProto::INVALID_SPEC,
prevent_inline_autocomplete, false, true, true,
ChromeAutocompleteSchemeClassifier(&profile_));
- provider_->Start(input, false);
+ provider_->Start(input, false, false);
EXPECT_TRUE(provider_->done());
ac_matches_ = provider_->matches();
@@ -821,6 +821,16 @@ TEST_F(ShortcutsProviderTest, DeleteMatch) {
backend_->shortcuts_map().find(ASCIIToUTF16("delete")));
}
+TEST_F(ShortcutsProviderTest, DoesNotProvideOnFocus) {
+ AutocompleteInput input(ASCIIToUTF16("about:o"), base::string16::npos,
+ std::string(), GURL(),
+ metrics::OmniboxEventProto::INVALID_SPEC,
+ false, false, true, true,
+ ChromeAutocompleteSchemeClassifier(&profile_));
+ provider_->Start(input, false, true);
+ EXPECT_TRUE(provider_->matches().empty());
+}
+
#if defined(ENABLE_EXTENSIONS)
TEST_F(ShortcutsProviderTest, Extension) {
// Try an input string that matches an extension URL.
« no previous file with comments | « chrome/browser/autocomplete/shortcuts_provider.cc ('k') | chrome/browser/autocomplete/zero_suggest_provider.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698