Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(749)

Unified Diff: chrome/browser/autocomplete/history_quick_provider_unittest.cc

Issue 836213002: Assume all providers may give zero suggest responses. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Fix compilation issue in athena Created 5 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/autocomplete/history_quick_provider_unittest.cc
diff --git a/chrome/browser/autocomplete/history_quick_provider_unittest.cc b/chrome/browser/autocomplete/history_quick_provider_unittest.cc
index a79c1f3ccd09decf898d09daa4827e51334671f6..fcb5838a1a3e2657b51b03809be66ef3a68d6402 100644
--- a/chrome/browser/autocomplete/history_quick_provider_unittest.cc
+++ b/chrome/browser/autocomplete/history_quick_provider_unittest.cc
@@ -292,7 +292,7 @@ void HistoryQuickProviderTest::RunTestWithCursor(
metrics::OmniboxEventProto::INVALID_SPEC,
prevent_inline_autocomplete, false, true, true,
ChromeAutocompleteSchemeClassifier(profile_.get()));
- provider_->Start(input, false);
+ provider_->Start(input, false, false);
EXPECT_TRUE(provider_->done());
ac_matches_ = provider_->matches();
@@ -714,6 +714,16 @@ TEST_F(HistoryQuickProviderTest, CullSearchResults) {
ASCIIToUTF16(".com"));
}
+TEST_F(HistoryQuickProviderTest, DoesNotProvideMatchesOnFocus) {
+ AutocompleteInput input(ASCIIToUTF16("popularsite"), base::string16::npos,
+ std::string(), GURL(),
+ metrics::OmniboxEventProto::INVALID_SPEC,
+ false, false, true, true,
+ ChromeAutocompleteSchemeClassifier(profile_.get()));
+ provider_->Start(input, false, true);
+ EXPECT_TRUE(provider_->matches().empty());
+}
+
// HQPOrderingTest -------------------------------------------------------------
TestURLInfo ordering_test_db[] = {
« no previous file with comments | « chrome/browser/autocomplete/history_quick_provider.cc ('k') | chrome/browser/autocomplete/history_url_provider.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698