Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(206)

Unified Diff: chrome/browser/autocomplete/builtin_provider_unittest.cc

Issue 836213002: Assume all providers may give zero suggest responses. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Fix compilation issue in athena Created 5 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/autocomplete/builtin_provider_unittest.cc
diff --git a/chrome/browser/autocomplete/builtin_provider_unittest.cc b/chrome/browser/autocomplete/builtin_provider_unittest.cc
index 916c314c3c2e5859dc622b1251bfbd6304b84ef7..108d8a666005619280fead8bb1fa6c4903286efd 100644
--- a/chrome/browser/autocomplete/builtin_provider_unittest.cc
+++ b/chrome/browser/autocomplete/builtin_provider_unittest.cc
@@ -42,7 +42,7 @@ class BuiltinProviderTest : public testing::Test {
metrics::OmniboxEventProto::INVALID_SPEC,
true, false, true, true,
ChromeAutocompleteSchemeClassifier(NULL));
- provider_->Start(input, false);
+ provider_->Start(input, false, false);
EXPECT_TRUE(provider_->done());
matches = provider_->matches();
EXPECT_EQ(cases[i].num_results, matches.size());
@@ -55,9 +55,9 @@ class BuiltinProviderTest : public testing::Test {
}
}
- private:
scoped_refptr<BuiltinProvider> provider_;
+ private:
DISALLOW_COPY_AND_ASSIGN(BuiltinProviderTest);
};
@@ -282,6 +282,17 @@ TEST_F(BuiltinProviderTest, AboutBlank) {
RunTest(about_blank_cases, arraysize(about_blank_cases));
}
+TEST_F(BuiltinProviderTest, DoesNotSupportMatchesOnFocus) {
+ const AutocompleteInput input(ASCIIToUTF16("chrome://s"),
+ base::string16::npos,
+ std::string(), GURL(),
+ metrics::OmniboxEventProto::INVALID_SPEC,
+ true, false, true, true,
+ ChromeAutocompleteSchemeClassifier(NULL));
+ provider_->Start(input, false, true);
+ EXPECT_TRUE(provider_->matches().empty());
+}
+
#if !defined(OS_ANDROID)
// Disabled on Android where we use native UI instead of chrome://settings.
TEST_F(BuiltinProviderTest, ChromeSettingsSubpages) {
« no previous file with comments | « chrome/browser/autocomplete/builtin_provider.cc ('k') | chrome/browser/autocomplete/history_quick_provider.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698