Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3704)

Unified Diff: chrome/browser/autocomplete/bookmark_provider_unittest.cc

Issue 836213002: Assume all providers may give zero suggest responses. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Fix compilation issue in athena Created 5 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/autocomplete/bookmark_provider.cc ('k') | chrome/browser/autocomplete/builtin_provider.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/autocomplete/bookmark_provider_unittest.cc
diff --git a/chrome/browser/autocomplete/bookmark_provider_unittest.cc b/chrome/browser/autocomplete/bookmark_provider_unittest.cc
index 78b8a683aead1ca73cd241667daf284bafc8a264..8995c5f0921eab49a3cc882666fc231c73a033a8 100644
--- a/chrome/browser/autocomplete/bookmark_provider_unittest.cc
+++ b/chrome/browser/autocomplete/bookmark_provider_unittest.cc
@@ -267,7 +267,7 @@ TEST_F(BookmarkProviderTest, Positions) {
metrics::OmniboxEventProto::INVALID_SPEC, false,
false, false, true,
ChromeAutocompleteSchemeClassifier(profile_.get()));
- provider_->Start(input, false);
+ provider_->Start(input, false, false);
const ACMatches& matches(provider_->matches());
// Validate number of results is as expected.
EXPECT_LE(matches.size(), query_data[i].match_count)
@@ -348,7 +348,7 @@ TEST_F(BookmarkProviderTest, Rankings) {
metrics::OmniboxEventProto::INVALID_SPEC, false,
false, false, true,
ChromeAutocompleteSchemeClassifier(profile_.get()));
- provider_->Start(input, false);
+ provider_->Start(input, false, false);
const ACMatches& matches(provider_->matches());
// Validate number and content of results is as expected.
for (size_t j = 0; j < std::max(query_data[i].match_count, matches.size());
@@ -448,7 +448,7 @@ TEST_F(BookmarkProviderTest, StripHttpAndAdjustOffsets) {
metrics::OmniboxEventProto::INVALID_SPEC, false,
false, false, true,
ChromeAutocompleteSchemeClassifier(profile_.get()));
- provider_->Start(input, false);
+ provider_->Start(input, false, false);
const ACMatches& matches(provider_->matches());
ASSERT_EQ(1U, matches.size()) << description;
const AutocompleteMatch& match = matches[0];
@@ -472,3 +472,13 @@ TEST_F(BookmarkProviderTest, StripHttpAndAdjustOffsets) {
}
}
}
+
+TEST_F(BookmarkProviderTest, DoesNotProvideMatchesOnFocus) {
+ AutocompleteInput input(base::ASCIIToUTF16("foo"),
+ base::string16::npos, std::string(), GURL(),
+ metrics::OmniboxEventProto::INVALID_SPEC, false,
+ false, false, true,
+ ChromeAutocompleteSchemeClassifier(profile_.get()));
+ provider_->Start(input, false, true);
+ EXPECT_TRUE(provider_->matches().empty());
+}
« no previous file with comments | « chrome/browser/autocomplete/bookmark_provider.cc ('k') | chrome/browser/autocomplete/builtin_provider.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698