chrome/browser/autocomplete/bookmark_provider.h - Issue 836213002: Assume all providers may give zero suggest responses.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/autocomplete/bookmark_provider.h

Issue 836213002: Assume all providers may give zero suggest responses. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Fix compilation issue in athena Created 5 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/autocomplete/autocomplete_provider_unittest.cc ('k') | chrome/browser/autocomplete/bookmark_provider.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/autocomplete/bookmark_provider.h

diff --git a/chrome/browser/autocomplete/bookmark_provider.h b/chrome/browser/autocomplete/bookmark_provider.h

index 8d42ab5ffdfc56490f169ccb03b33f1ad9d6f39c..d3fa12afa03cbaa7a748bbb8cdb799e97cf37ace 100644

--- a/chrome/browser/autocomplete/bookmark_provider.h

+++ b/chrome/browser/autocomplete/bookmark_provider.h

@@ -34,7 +34,9 @@ class BookmarkProvider : public AutocompleteProvider {

// When |minimal_changes| is true short circuit any additional searching and

// leave the previous matches for this provider unchanged, otherwise perform

// a complete search for |input| across all bookmark titles.

- void Start(const AutocompleteInput& input, bool minimal_changes) override;

+ void Start(const AutocompleteInput& input,

+ bool minimal_changes,

+ bool called_due_to_focus) override;

// Sets the BookmarkModel for unit tests.

void set_bookmark_model_for_testing(BookmarkModel* bookmark_model) {

« no previous file with comments | « chrome/browser/autocomplete/autocomplete_provider_unittest.cc ('k') | chrome/browser/autocomplete/bookmark_provider.cc » ('j') | no next file with comments »