Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4105)

Unified Diff: chrome/browser/autocomplete/autocomplete_controller.cc

Issue 836213002: Assume all providers may give zero suggest responses. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Fix compilation issue in athena Created 5 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/autocomplete/autocomplete_controller.cc
diff --git a/chrome/browser/autocomplete/autocomplete_controller.cc b/chrome/browser/autocomplete/autocomplete_controller.cc
index b23c215c4b380903b0a564ce4acc63f74e81e679..44e8f85623f378789d63d400a873ed184897d16c 100644
--- a/chrome/browser/autocomplete/autocomplete_controller.cc
+++ b/chrome/browser/autocomplete/autocomplete_controller.cc
@@ -262,14 +262,7 @@ void AutocompleteController::Start(const AutocompleteInput& input) {
// TODO(mpearson): Remove timing code once bugs 178705 / 237703 / 168933
// are resolved.
base::TimeTicks provider_start_time = base::TimeTicks::Now();
-
- // Call Start() on ZeroSuggestProvider with an INVALID AutocompleteInput
- // to clear out zero-suggest |matches_|.
- if (i->get() == zero_suggest_provider_)
- (*i)->Start(AutocompleteInput(), minimal_changes);
- else
- (*i)->Start(input_, minimal_changes);
-
+ (*i)->Start(input_, minimal_changes, false);
if (!input.want_asynchronous_matches())
DCHECK((*i)->done());
base::TimeTicks provider_end_time = base::TimeTicks::Now();
@@ -333,12 +326,8 @@ void AutocompleteController::OnOmniboxFocused(const AutocompleteInput& input) {
// Call Start() on all prefix-based providers with an INVALID
// AutocompleteInput to clear out cached |matches_|, which ensures that
// they aren't used with zero suggest.
- for (Providers::iterator i(providers_.begin()); i != providers_.end(); ++i) {
- if ((*i)->ProvidesMatchesOnOmniboxFocus())
- (*i)->Start(input, false);
- else
- (*i)->Start(AutocompleteInput(), false);
- }
+ for (Providers::iterator i(providers_.begin()); i != providers_.end(); ++i)
+ (*i)->Start(input, false, true);
UpdateResult(false, false);
}
« no previous file with comments | « chrome/browser/autocomplete/autocomplete_controller.h ('k') | chrome/browser/autocomplete/autocomplete_provider_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698