Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(89)

Side by Side Diff: components/omnibox/autocomplete_provider.cc

Issue 836213002: Assume all providers may give zero suggest responses. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Fix compilation issue in athena Created 5 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2014 The Chromium Authors. All rights reserved. 1 // Copyright 2014 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "components/omnibox/autocomplete_provider.h" 5 #include "components/omnibox/autocomplete_provider.h"
6 6
7 #include "base/logging.h" 7 #include "base/logging.h"
8 #include "base/strings/utf_string_conversions.h" 8 #include "base/strings/utf_string_conversions.h"
9 #include "components/omnibox/autocomplete_input.h" 9 #include "components/omnibox/autocomplete_input.h"
10 #include "components/omnibox/autocomplete_match.h" 10 #include "components/omnibox/autocomplete_match.h"
(...skipping 31 matching lines...) Expand 10 before | Expand all | Expand 10 after
42 default: 42 default:
43 NOTREACHED() << "Unhandled AutocompleteProvider::Type " << type; 43 NOTREACHED() << "Unhandled AutocompleteProvider::Type " << type;
44 return "Unknown"; 44 return "Unknown";
45 } 45 }
46 } 46 }
47 47
48 void AutocompleteProvider::Stop(bool clear_cached_results) { 48 void AutocompleteProvider::Stop(bool clear_cached_results) {
49 done_ = true; 49 done_ = true;
50 } 50 }
51 51
52 bool AutocompleteProvider::ProvidesMatchesOnOmniboxFocus() const {
53 return false;
54 }
55
56 const char* AutocompleteProvider::GetName() const { 52 const char* AutocompleteProvider::GetName() const {
57 return TypeToString(type_); 53 return TypeToString(type_);
58 } 54 }
59 55
60 metrics::OmniboxEventProto_ProviderType AutocompleteProvider:: 56 metrics::OmniboxEventProto_ProviderType AutocompleteProvider::
61 AsOmniboxEventProviderType() const { 57 AsOmniboxEventProviderType() const {
62 switch (type_) { 58 switch (type_) {
63 case TYPE_BOOKMARK: 59 case TYPE_BOOKMARK:
64 return metrics::OmniboxEventProto::BOOKMARK; 60 return metrics::OmniboxEventProto::BOOKMARK;
65 case TYPE_BUILTIN: 61 case TYPE_BUILTIN:
(...skipping 114 matching lines...) Expand 10 before | Expand all | Expand 10 after
180 DCHECK_NE(base::string16::npos, scheme_pos); 176 DCHECK_NE(base::string16::npos, scheme_pos);
181 177
182 // Erase scheme plus up to two slashes. 178 // Erase scheme plus up to two slashes.
183 size_t prefix_end = scheme_pos + strlen(url::kHttpScheme) + 1; 179 size_t prefix_end = scheme_pos + strlen(url::kHttpScheme) + 1;
184 const size_t after_slashes = std::min(url->length(), prefix_end + 2); 180 const size_t after_slashes = std::min(url->length(), prefix_end + 2);
185 while ((prefix_end < after_slashes) && ((*url)[prefix_end] == '/')) 181 while ((prefix_end < after_slashes) && ((*url)[prefix_end] == '/'))
186 ++prefix_end; 182 ++prefix_end;
187 url->erase(scheme_pos, prefix_end - scheme_pos); 183 url->erase(scheme_pos, prefix_end - scheme_pos);
188 return (scheme_pos == 0) ? prefix_end : 0; 184 return (scheme_pos == 0) ? prefix_end : 0;
189 } 185 }
OLDNEW
« no previous file with comments | « components/omnibox/autocomplete_provider.h ('k') | components/omnibox/base_search_provider_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698