Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(18)

Unified Diff: webkit/plugins/ppapi/ppapi_plugin_instance.h

Issue 8362021: Remove unused argument that was not cleaned up in (Closed) Base URL: svn://chrome-svn/chrome/trunk/src/
Patch Set: '' Created 9 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | webkit/plugins/ppapi/ppapi_plugin_instance.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: webkit/plugins/ppapi/ppapi_plugin_instance.h
===================================================================
--- webkit/plugins/ppapi/ppapi_plugin_instance.h (revision 107024)
+++ webkit/plugins/ppapi/ppapi_plugin_instance.h (working copy)
@@ -272,13 +272,12 @@
// fullscreen_ = true
bool IsFullscreenOrPending();
- // Switches between fullscreen and normal mode. If |delay_report| is set to
- // false, it may report the new state through DidChangeView immediately. If
- // true, it will delay it. When called from the plugin, delay_report should be
- // true to avoid re-entrancy. Returns true on success, false on failure
- // (e.g. trying to enter fullscreen when not processing a user gesture or
- // trying to set fullscreen when already in fullscreen mode).
- bool SetFullscreen(bool fullscreen, bool delay_report);
+ // Switches between fullscreen and normal mode. The transition is
+ // asynchronous. WebKit will trigger corresponding VewChanged calls.
+ // Returns true on success, false on failure (e.g. trying to enter fullscreen
+ // when not processing a user gesture or trying to set fullscreen when
+ // already in fullscreen mode).
+ bool SetFullscreen(bool fullscreen);
// Implementation of PPB_Flash.
int32_t Navigate(PPB_URLRequestInfo_Impl* request,
« no previous file with comments | « no previous file | webkit/plugins/ppapi/ppapi_plugin_instance.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698