Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(82)

Issue 836193003: Combine match methods on StyleResolver. (Closed)

Created:
5 years, 11 months ago by esprehn
Modified:
5 years, 11 months ago
Reviewers:
ojan
CC:
ojan, abarth-chromium, mojo-reviews_chromium.org
Base URL:
git@github.com:domokit/mojo.git@master
Target Ref:
refs/heads/master
Project:
mojo
Visibility:
Public.

Description

Combine match methods on StyleResolver. We can combine matchAuthorRulesForShadowHost into matchAuthorRules, and also combine the two matchUARules methods. collectScopedResolversForHostedShadowTrees and the Vector of ScopedStyleResolvers was also not needed. Sky can only ever have two resolvers, the one for your scope, and the one for your host rules. R=ojan@chromium.org Committed: https://chromium.googlesource.com/external/mojo/+/11781634cabe9fd48091d88d021a3c35e387848e

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+17 lines, -62 lines) Patch
M sky/engine/core/css/resolver/StyleResolver.h View 1 chunk +1 line, -5 lines 0 comments Download
M sky/engine/core/css/resolver/StyleResolver.cpp View 3 chunks +16 lines, -57 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
esprehn
5 years, 11 months ago (2015-01-07 20:26:16 UTC) #2
ojan
lgtm
5 years, 11 months ago (2015-01-07 23:29:22 UTC) #3
esprehn
5 years, 11 months ago (2015-01-08 18:17:08 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
11781634cabe9fd48091d88d021a3c35e387848e (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698