Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(172)

Unified Diff: sky/specs/dom.md

Issue 836193002: Specs: Move default layout manager stuff from default styles to getLayoutManager() (Closed) Base URL: https://github.com/domokit/mojo.git@master
Patch Set: Created 5 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | sky/specs/modules.md » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: sky/specs/dom.md
diff --git a/sky/specs/dom.md b/sky/specs/dom.md
index 6dc8230a90b3f8a4620ec57bf750f3b053d99bca..2f1cb860fcc7515c02298202a516edfec7e425ef 100644
--- a/sky/specs/dom.md
+++ b/sky/specs/dom.md
@@ -123,7 +123,7 @@ class Document : TreeScope {
constructor (ChildArguments... nodes); // O(N) in number of arguments plus all their descendants
virtual LayoutManagerConstructor getLayoutManager(); // O(1)
- // default implementation returns sky.rootLayoutManager;
+ // returns sky.rootLayoutManager;
}
attribute LayoutManagerConstructor rootLayoutManager; // O(1)
@@ -139,6 +139,9 @@ class ImportElement : Element {
constructor (); // shorthand
constructor attribute String tagName; // O(1) // "import"
constructor attribute Boolean shadow; // O(1) // false
+
+ virtual LayoutManagerConstructor getLayoutManager(); // O(1)
+ // returns null
}
class TemplateElement : Element {
constructor (Dictionary<String> attributes, ChildArguments... nodes); // O(M+N), M = number of attributes, N = number of nodes plus all their descendants
@@ -149,6 +152,8 @@ class TemplateElement : Element {
constructor attribute Boolean shadow; // O(1) // false
readonly attribute DocumentFragment content; // O(1)
+ virtual LayoutManagerConstructor getLayoutManager(); // O(1)
+ // returns null
}
class ScriptElement : Element {
constructor (Dictionary<String> attributes, ChildArguments... nodes); // O(M+N), M = number of attributes, N = number of nodes plus all their descendants
@@ -157,6 +162,9 @@ class ScriptElement : Element {
constructor (); // shorthand
constructor attribute String tagName; // O(1) // "script"
constructor attribute Boolean shadow; // O(1) // false
+
+ virtual LayoutManagerConstructor getLayoutManager(); // O(1)
+ // returns null
}
class StyleElement : Element {
constructor (Dictionary<String> attributes, ChildArguments... nodes); // O(M+N), M = number of attributes, N = number of nodes plus all their descendants
@@ -167,6 +175,8 @@ class StyleElement : Element {
constructor attribute Boolean shadow; // O(1) // false
Array<Rule> getRules(); // O(N) in rules
+ virtual LayoutManagerConstructor getLayoutManager(); // O(1)
+ // returns null
}
class ContentElement : Element {
constructor (Dictionary<String> attributes, ChildArguments... nodes); // O(M+N), M = number of attributes, N = number of nodes plus all their descendants
@@ -177,6 +187,8 @@ class ContentElement : Element {
constructor attribute Boolean shadow; // O(1) // false
Array<Node> getDistributedNodes(); // O(N) in distributed nodes
+ virtual LayoutManagerConstructor getLayoutManager(); // O(1)
+ // returns null
}
class ImgElement : Element {
constructor (Dictionary<String> attributes, ChildArguments... nodes); // O(M+N), M = number of attributes, N = number of nodes plus all their descendants
@@ -185,6 +197,9 @@ class ImgElement : Element {
constructor (); // shorthand
constructor attribute String tagName; // O(1) // "img"
constructor attribute Boolean shadow; // O(1) // false
+
+ virtual LayoutManagerConstructor getLayoutManager(); // O(1)
+ // returns ImgElementLayoutManager
}
class DivElement : Element {
constructor (Dictionary<String> attributes, ChildArguments... nodes); // O(M+N), M = number of attributes, N = number of nodes plus all their descendants
@@ -209,6 +224,9 @@ class IframeElement : Element {
constructor (); // shorthand
constructor attribute String tagName; // O(1) // "iframe"
constructor attribute Boolean shadow; // O(1) // false
+
+ virtual LayoutManagerConstructor getLayoutManager(); // O(1)
+ // returns IframeElementLayoutManager
}
class TElement : Element {
constructor (Dictionary<String> attributes, ChildArguments... nodes); // O(M+N), M = number of attributes, N = number of nodes plus all their descendants
@@ -233,6 +251,9 @@ class TitleElement : Element {
constructor (); // shorthand
constructor attribute String tagName; // O(1) // "title"
constructor attribute Boolean shadow; // O(1) // false
+
+ virtual LayoutManagerConstructor getLayoutManager(); // O(1)
+ // returns null
}
class ErrorElement : Element {
constructor (Dictionary<String> attributes, ChildArguments... nodes); // O(M+N), M = number of attributes, N = number of nodes plus all their descendants
@@ -241,6 +262,9 @@ class ErrorElement : Element {
constructor (); // shorthand
constructor attribute String tagName; // O(1) // "error"
constructor attribute Boolean shadow; // O(1) // false
+
+ virtual LayoutManagerConstructor getLayoutManager(); // O(1)
+ // returns ErrorElementLayoutManager
}
callback InternalElementConstructor void (Module module);
« no previous file with comments | « no previous file | sky/specs/modules.md » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698