Mac: Fix sheet positioning on popup windows.

Mac: Fix sheet positioning on popup windows.

Popup windows don't have bookmark bars, so check for supportsBookmarkBar
before trying to position the sheet next to the bookmark bar.
Fix incorrect use of defaultSheetRect.size.height, it has no meaning according
to AppKit docs.

BUG=436959
Committed: https://crrev.com/8e236456ec39379944823698e3b9d083fbf3979e
Cr-Commit-Position: refs/heads/master@{#310187}

[Andre, 2015-01-06 18:33:23]

Patchset #1 (id:1) has been deleted

[Andre, 2015-01-06 20:55:33]

andresantoso@chromium.org changed reviewers:
+ rsesek@chromium.org

[Andre, 2015-01-06 20:55:33]

Robert, please review.

https://codereview.chromium.org/836173002/diff/20001/chrome/browser/ui/cocoa/...
File chrome/browser/ui/cocoa/browser_window_controller_private.mm (left):

https://codereview.chromium.org/836173002/diff/20001/chrome/browser/ui/cocoa/...
chrome/browser/ui/cocoa/browser_window_controller_private.mm:199:
defaultSheetRect.size.height;
This height has no meaning according to AppKit docs, defaultSheetRect is not
actually the frame of the sheet.

https://codereview.chromium.org/836173002/diff/20001/chrome/browser/ui/cocoa/...
File chrome/browser/ui/cocoa/browser_window_controller_private.mm (right):

https://codereview.chromium.org/836173002/diff/20001/chrome/browser/ui/cocoa/...
chrome/browser/ui/cocoa/browser_window_controller_private.mm:184: if ([self
supportsBookmarkBar] &&
This was the missing check that caused the sheet to be positioned incorrectly on
popup windows.

[Robert Sesek, 2015-01-06 23:44:00]

LGTM

[Andre, 2015-01-06 23:45:30]

The CQ bit was checked by andresantoso@chromium.org

[commit-bot: I haz the power, 2015-01-06 23:46:23]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/836173002/20001

[commit-bot: I haz the power, 2015-01-07 00:28:29]

Committed patchset #1 (id:20001)

[commit-bot: I haz the power, 2015-01-07 00:30:35]

Patchset 1 (id:??) landed as
https://crrev.com/8e236456ec39379944823698e3b9d083fbf3979e
Cr-Commit-Position: refs/heads/master@{#310187}