Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(43)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 836153004: [docs] better links in devtools api docs (Closed)

Created:
5 years, 11 months ago by paulirish
Modified:
5 years, 10 months ago
Reviewers:
mkearney1
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[docs] better links in devtools api docs BUG= Committed: https://crrev.com/5424909d2a74b3f2af7fe4a7b2dce4c7b013bdd2 Cr-Commit-Position: refs/heads/master@{#316644}

Patch Set 1 #

Patch Set 2 : #

Total comments: 1

Patch Set 3 : end p tag #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -4 lines) Patch
M chrome/common/extensions/api/debugger.json View 1 chunk +1 line, -1 line 0 comments Download
M chrome/common/extensions/docs/templates/articles/devtools.html View 1 2 2 chunks +6 lines, -3 lines 0 comments Download

Messages

Total messages: 10 (3 generated)
paulirish
5 years, 11 months ago (2015-01-06 19:44:25 UTC) #2
paulirish
ptal
5 years, 11 months ago (2015-01-12 02:07:02 UTC) #3
paulirish
ping
5 years, 10 months ago (2015-02-16 21:39:23 UTC) #4
mkearney1
lgtm With a small nit... https://codereview.chromium.org/836153004/diff/20001/chrome/common/extensions/docs/templates/articles/devtools.html File chrome/common/extensions/docs/templates/articles/devtools.html (right): https://codereview.chromium.org/836153004/diff/20001/chrome/common/extensions/docs/templates/articles/devtools.html#newcode410 chrome/common/extensions/docs/templates/articles/devtools.html:410: the background script, and ...
5 years, 10 months ago (2015-02-17 19:08:02 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/836153004/40001
5 years, 10 months ago (2015-02-17 19:31:49 UTC) #8
commit-bot: I haz the power
Committed patchset #3 (id:40001)
5 years, 10 months ago (2015-02-17 20:28:10 UTC) #9
commit-bot: I haz the power
5 years, 10 months ago (2015-02-17 20:28:58 UTC) #10
Message was sent while issue was closed. 
Patchset 3 (id:??) landed as
https://crrev.com/5424909d2a74b3f2af7fe4a7b2dce4c7b013bdd2
Cr-Commit-Position: refs/heads/master@{#316644}

Powered by Google App Engine
This is Rietveld 408576698