Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(8)

Issue 836143002: add flags to (for now) ignore conics when drawing ovals/rrects (Closed)

Created:
5 years, 11 months ago by reed1
Modified:
5 years, 11 months ago
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

add flags to (for now) ignore conics when drawing ovals/rrects BUG= Committed: https://crrev.com/79da8d544ed230b6da4fde2f8a2f755a6341547d Cr-Commit-Position: refs/heads/master@{#310102}

Patch Set 1 #

Total comments: 1

Patch Set 2 : oops, forgot skia already defined this, so need the double-dance #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -0 lines) Patch
M skia/config/SkUserConfig.h View 1 1 chunk +8 lines, -0 lines 0 comments Download

Messages

Total messages: 13 (5 generated)
reed1
these would be in our skia_for_chromium file, but they eventually need to be in userconfig, ...
5 years, 11 months ago (2015-01-06 15:28:06 UTC) #2
reed1
ptal
5 years, 11 months ago (2015-01-06 15:36:53 UTC) #3
robertphillips
lgtm + a question https://codereview.chromium.org/836143002/diff/1/skia/config/SkUserConfig.h File skia/config/SkUserConfig.h (right): https://codereview.chromium.org/836143002/diff/1/skia/config/SkUserConfig.h#newcode271 skia/config/SkUserConfig.h:271: Why not the usual #ifndef ...
5 years, 11 months ago (2015-01-06 15:40:27 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/836143002/1
5 years, 11 months ago (2015-01-06 16:04:55 UTC) #7
commit-bot: I haz the power
Try jobs failed on following builders: android_chromium_gn_compile_rel on tryserver.chromium.linux (http://build.chromium.org/p/tryserver.chromium.linux/builders/android_chromium_gn_compile_rel/builds/46936)
5 years, 11 months ago (2015-01-06 16:12:45 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/836143002/20001
5 years, 11 months ago (2015-01-06 16:15:57 UTC) #11
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 11 months ago (2015-01-06 17:30:00 UTC) #12
commit-bot: I haz the power
5 years, 11 months ago (2015-01-06 17:31:11 UTC) #13
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/79da8d544ed230b6da4fde2f8a2f755a6341547d
Cr-Commit-Position: refs/heads/master@{#310102}

Powered by Google App Engine
This is Rietveld 408576698