Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(68)

Issue 836123007: Use Math.ceil() instead of FloatMath.ceil() in TitleBitmapFactory class. (Closed)

Created:
5 years, 11 months ago by wajahat
Modified:
5 years, 11 months ago
CC:
chromium-reviews, darin-cc_chromium.org, jam
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Use Math.ceil() instead of FloatMath.ceil() in TitleBitmapFactory class. Below lint warnings were reported which is legitimate: org/chromium/chrome/browser/compositor/layouts/content/TitleBitmapFactory.class Use `java.lang.Math#ceil` instead of `android.util.FloatMath#ceil()` since it is faster as of API 8: FloatMath [warning] FloatMath.ceil() will be significantly slower on versions of Android with a JIT. The equivalent Math.ceil() is faster hence using the same. BUG=None. Committed: https://crrev.com/69e50e5ff7c33127bd4e5c11f751156ac5c786ff Cr-Commit-Position: refs/heads/master@{#311631}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -3 lines) Patch
M chrome/android/java/src/org/chromium/chrome/browser/compositor/layouts/content/TitleBitmapFactory.java View 3 chunks +2 lines, -3 lines 0 comments Download

Messages

Total messages: 13 (3 generated)
wajahat
Pl. review, Thanks!
5 years, 11 months ago (2015-01-13 12:08:57 UTC) #2
Jaekyun Seok (inactive)
On 2015/01/13 12:08:57, wajahat wrote: > Pl. review, Thanks! The sentence "Using Math.ceil() as FloatMath.ceil() ...
5 years, 11 months ago (2015-01-14 00:20:34 UTC) #3
wajahat
On 2015/01/14 00:20:34, Jaekyun Seok wrote: > On 2015/01/13 12:08:57, wajahat wrote: > > Pl. ...
5 years, 11 months ago (2015-01-14 05:27:09 UTC) #4
Jaekyun Seok (inactive)
lgtm
5 years, 11 months ago (2015-01-14 06:12:43 UTC) #6
wajahat
On 2015/01/14 06:12:43, Jaekyun Seok wrote: > lgtm Thanks Jaekyun @Nyquist/DTrainor, Could you have a ...
5 years, 11 months ago (2015-01-14 07:28:46 UTC) #7
David Trainor- moved to gerrit
lgtm
5 years, 11 months ago (2015-01-14 18:28:20 UTC) #8
nyquist
lgtm
5 years, 11 months ago (2015-01-14 18:32:56 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/836123007/1
5 years, 11 months ago (2015-01-15 05:14:35 UTC) #11
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 11 months ago (2015-01-15 06:03:26 UTC) #12
commit-bot: I haz the power
5 years, 11 months ago (2015-01-15 06:04:11 UTC) #13
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/69e50e5ff7c33127bd4e5c11f751156ac5c786ff
Cr-Commit-Position: refs/heads/master@{#311631}

Powered by Google App Engine
This is Rietveld 408576698