Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(88)

Issue 836103002: Revert of Add tab support to RenderBlockLineLayout::stripTrailingSpace (Closed)

Created:
5 years, 11 months ago by falken
Modified:
5 years, 11 months ago
Reviewers:
pdr., eae
CC:
blink-reviews, blink-reviews-rendering, Dominik Röttsches, eae+blinkwatch, jchaffraix+rendering, leviw+renderwatch, pdr+renderingwatchlist_chromium.org, zoltan1
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Revert of Add tab support to RenderBlockLineLayout::stripTrailingSpace (patchset #1 id:1 of https://codereview.chromium.org/836863002/) Reason for revert: trailing_whitespace_wrapping.html is crashing on Mac10.6 (dbg) http://test-results.appspot.com/dashboards/flakiness_dashboard.html#tests=fast%2Ftext%2Ftrailing_whitespace_wrapping.html%2Cvirtual%2Fantialiasedtext%2Ffast%2Ftext%2Ftrailing_whitespace_wrapping.html%2Cvirtual%2Fslimmingpaint%2Ffast%2Ftext%2Ftrailing_whitespace_wrapping.html Example: 22:23:47.008 3912 worker/4 fast/text/trailing_whitespace_wrapping.html crashed, (stderr lines): 22:23:47.008 3912 Assertion failed: (bool (status_and & kCTRunStatusRightToLeft) == backward), function _hb_coretext_shape, file ../../third_party/harfbuzz-ng/src/hb-coretext.cc, line 989. 22:23:47.009 3881 [30380/38782] fast/text/trailing_whitespace_wrapping.html failed unexpectedly (renderer crashed [pid=6953]) Original issue's description: > Add tab support to RenderBlockLineLayout::stripTrailingSpace > > Change RenderBlockLineLayout::stripTrailingSpace to measure the width of > the first trailing white-space character instead of always assuming it's > a space character. This fixes a bug where we wrap text unnecessarily for > elements with a trailing tab character as we correctly measure the right > character (tab) when computing the preferred with but subtract the width > of a space character in stripTrailingSpace. > > R=pdr@chromium.org > BUG=444544 > TEST=fast/text/trailing_whitespace_wrapping.html > > Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=187878 TBR=pdr@chromium.org,eae@chromium.org NOTREECHECKS=true NOTRY=true BUG=444544 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=187897

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -83 lines) Patch
D LayoutTests/fast/text/trailing_whitespace_wrapping.html View 1 chunk +0 lines, -32 lines 0 comments Download
D LayoutTests/fast/text/trailing_whitespace_wrapping-expected.html View 1 chunk +0 lines, -32 lines 0 comments Download
M Source/core/rendering/RenderBlockLineLayout.cpp View 1 chunk +8 lines, -19 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
falken
Created Revert of Add tab support to RenderBlockLineLayout::stripTrailingSpace
5 years, 11 months ago (2015-01-06 06:52:09 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/836103002/1
5 years, 11 months ago (2015-01-06 06:58:52 UTC) #3
commit-bot: I haz the power
5 years, 11 months ago (2015-01-06 06:59:25 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://src.chromium.org/viewvc/blink?view=rev&revision=187897

Powered by Google App Engine
This is Rietveld 408576698