Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(173)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 836093007: split api call stubs into accessor and function call stubs (Closed)

Created:
5 years, 11 months ago by dcarney
Modified:
5 years, 11 months ago
CC:
jochen (gone - plz use gerrit), v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

split api call stubs into accessor and function call stubs BUG= Committed: https://crrev.com/6950ead0b0a8373441dc8f8d3b2c316e82549ce9 Cr-Commit-Position: refs/heads/master@{#26097}

Patch Set 1 : #

Patch Set 2 : #

Patch Set 3 : cp #

Patch Set 4 : #

Patch Set 5 : #

Patch Set 6 : #

Patch Set 7 : #

Patch Set 8 : #

Patch Set 9 : ia32 #

Patch Set 10 : x32 #

Patch Set 11 : x64 size opts #

Patch Set 12 : ia32 size opts #

Patch Set 13 : added back call_data_undefined optimization #

Patch Set 14 : drop shift #

Patch Set 15 : cleanup #

Patch Set 16 : arm #

Total comments: 1

Patch Set 17 : arm64 #

Patch Set 18 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+547 lines, -254 lines) Patch
M include/v8.h View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 2 chunks +2 lines, -2 lines 0 comments Download
M src/arm/code-stubs-arm.cc View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 6 chunks +62 lines, -30 lines 0 comments Download
M src/arm/interface-descriptors-arm.cc View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 1 chunk +25 lines, -0 lines 0 comments Download
M src/arm/macro-assembler-arm.h View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 2 chunks +5 lines, -5 lines 0 comments Download
M src/arm/macro-assembler-arm.cc View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 4 chunks +16 lines, -10 lines 0 comments Download
M src/arm64/code-stubs-arm64.cc View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 6 chunks +61 lines, -29 lines 0 comments Download
M src/arm64/interface-descriptors-arm64.cc View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 1 chunk +25 lines, -0 lines 0 comments Download
M src/arm64/macro-assembler-arm64.h View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 1 chunk +2 lines, -2 lines 0 comments Download
M src/arm64/macro-assembler-arm64.cc View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 2 chunks +12 lines, -7 lines 0 comments Download
M src/code-stubs.h View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 3 chunks +25 lines, -12 lines 0 comments Download
M src/hydrogen.cc View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 4 chunks +28 lines, -23 lines 0 comments Download
M src/ia32/code-stubs-ia32.cc View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 7 chunks +69 lines, -37 lines 0 comments Download
M src/ia32/interface-descriptors-ia32.cc View 1 2 3 4 5 6 7 8 1 chunk +21 lines, -0 lines 0 comments Download
M src/ia32/macro-assembler-ia32.h View 1 2 3 4 5 6 7 8 1 chunk +2 lines, -2 lines 0 comments Download
M src/ia32/macro-assembler-ia32.cc View 1 2 3 4 5 6 7 8 9 10 11 12 13 2 chunks +14 lines, -7 lines 0 comments Download
M src/ic/arm/handler-compiler-arm.cc View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 2 chunks +7 lines, -8 lines 0 comments Download
M src/ic/arm64/handler-compiler-arm64.cc View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 2 chunks +7 lines, -7 lines 0 comments Download
M src/ic/handler-compiler.h View 1 2 3 4 5 6 7 8 1 chunk +5 lines, -5 lines 0 comments Download
M src/ic/handler-compiler.cc View 1 2 3 4 5 6 7 8 2 chunks +4 lines, -5 lines 0 comments Download
M src/ic/ia32/handler-compiler-ia32.cc View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 2 chunks +7 lines, -8 lines 0 comments Download
M src/ic/x64/handler-compiler-x64.cc View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 2 chunks +7 lines, -8 lines 0 comments Download
M src/interface-descriptors.h View 2 chunks +8 lines, -1 line 0 comments Download
M src/x64/code-stubs-x64.cc View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 7 chunks +72 lines, -36 lines 0 comments Download
M src/x64/interface-descriptors-x64.cc View 1 chunk +21 lines, -0 lines 0 comments Download
M src/x64/macro-assembler-x64.h View 1 2 3 4 5 1 chunk +2 lines, -2 lines 0 comments Download
M src/x64/macro-assembler-x64.cc View 1 2 3 4 5 6 7 8 9 10 11 12 13 2 chunks +14 lines, -7 lines 0 comments Download
M test/cctest/test-api.cc View 1 2 3 4 5 6 7 8 9 10 11 12 13 1 chunk +24 lines, -1 line 0 comments Download

Messages

Total messages: 15 (9 generated)
jochen (gone - plz use gerrit)
https://codereview.chromium.org/836093007/diff/390001/src/ic/arm/handler-compiler-arm.cc File src/ic/arm/handler-compiler-arm.cc (left): https://codereview.chromium.org/836093007/diff/390001/src/ic/arm/handler-compiler-arm.cc#oldcode277 src/ic/arm/handler-compiler-arm.cc:277: bool call_data_undefined = false; nit. undo this change
5 years, 11 months ago (2015-01-15 19:28:24 UTC) #7
dcarney
On 2015/01/15 19:28:24, jochen (slow) wrote: > https://codereview.chromium.org/836093007/diff/390001/src/ic/arm/handler-compiler-arm.cc > File src/ic/arm/handler-compiler-arm.cc (left): > > https://codereview.chromium.org/836093007/diff/390001/src/ic/arm/handler-compiler-arm.cc#oldcode277 ...
5 years, 11 months ago (2015-01-16 08:29:12 UTC) #10
jochen (gone - plz use gerrit)
lgtm
5 years, 11 months ago (2015-01-16 10:09:20 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/836093007/470001
5 years, 11 months ago (2015-01-16 10:23:35 UTC) #13
commit-bot: I haz the power
Committed patchset #18 (id:470001)
5 years, 11 months ago (2015-01-16 10:59:13 UTC) #14
commit-bot: I haz the power
5 years, 11 months ago (2015-01-16 10:59:24 UTC) #15
Message was sent while issue was closed. 
Patchset 18 (id:??) landed as
https://crrev.com/6950ead0b0a8373441dc8f8d3b2c316e82549ce9
Cr-Commit-Position: refs/heads/master@{#26097}

Powered by Google App Engine
This is Rietveld 408576698