Remove dead code related to base::JsonPrefStore without a path.

base/prefs/json_pref_store.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "base/prefs/json_pref_store.h"
 
 #include <algorithm>
 
 #include "base/bind.h"
 #include "base/callback.h"
@@ skipping 239 matching lines @@
 }
 
 PersistentPrefStore::PrefReadError JsonPrefStore::GetReadError() const {
   DCHECK(CalledOnValidThread());
 
   return read_error_;
 }
 
 PersistentPrefStore::PrefReadError JsonPrefStore::ReadPrefs() {
   DCHECK(CalledOnValidThread());
-
-  if (path_.empty()) {
-    scoped_ptr<ReadResult> no_file_result;
-    no_file_result->error = PREF_READ_ERROR_FILE_NOT_SPECIFIED;
-    OnFileRead(no_file_result.Pass());
-    return PREF_READ_ERROR_FILE_NOT_SPECIFIED;
-  }
+  DCHECK(!path_.empty());

[Bernhard Bauer, 2015/01/07 11:01:03]

Can we do this check at construction time?

[Daniel Bratell, 2015/01/07 13:44:34]

Done.

 
   OnFileRead(ReadPrefsFromDisk(path_, alternate_path_));
   return filtering_in_progress_ ? PREF_READ_ERROR_ASYNCHRONOUS_TASK_INCOMPLETE
                                 : read_error_;
 }
 
 void JsonPrefStore::ReadPrefsAsync(ReadErrorDelegate* error_delegate) {
   DCHECK(CalledOnValidThread());
+  DCHECK(!path_.empty());
 
   initialized_ = false;
   error_delegate_.reset(error_delegate);
-  if (path_.empty()) {
-    scoped_ptr<ReadResult> no_file_result;
-    no_file_result->error = PREF_READ_ERROR_FILE_NOT_SPECIFIED;
-    OnFileRead(no_file_result.Pass());
-    return;
-  }
 
   // Weakly binds the read task so that it doesn't kick in during shutdown.
   base::PostTaskAndReplyWithResult(
       sequenced_task_runner_.get(),
       FROM_HERE,
       base::Bind(&ReadPrefsFromDisk, path_, alternate_path_),
       base::Bind(&JsonPrefStore::OnFileRead, AsWeakPtr()));
 }
 
 void JsonPrefStore::CommitPendingWrite() {
@@ skipping 142 matching lines @@
 
   if (error_delegate_ && read_error_ != PREF_READ_ERROR_NONE)
     error_delegate_->OnError(read_error_);
 
   FOR_EACH_OBSERVER(PrefStore::Observer,
                     observers_,
                     OnInitializationCompleted(true));
 
   return;
 }