content/common/gpu/media/v4l2_video_decode_accelerator.h - Issue 836093002: V4L2VDA: Fix format initialization order.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/common/gpu/media/v4l2_video_decode_accelerator.h

Issue 836093002: V4L2VDA: Fix format initialization order. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 5 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: content/common/gpu/media/v4l2_video_decode_accelerator.h

diff --git a/content/common/gpu/media/v4l2_video_decode_accelerator.h b/content/common/gpu/media/v4l2_video_decode_accelerator.h

index 9eb04feb8fa203f46f9b6c13594ee91fc83002f2..c6da742fc5491e9bdcbdfd9a965bd26c9dd4d84f 100644

--- a/content/common/gpu/media/v4l2_video_decode_accelerator.h

+++ b/content/common/gpu/media/v4l2_video_decode_accelerator.h

@@ -275,9 +275,8 @@ class CONTENT_EXPORT V4L2VideoDecodeAccelerator

bool CreateInputBuffers();

bool CreateOutputBuffers();

- // Query the hardware for a suitable format that we can use for

- // importing into EGLImages for output, and set it.

- bool SetupOutputFormat();

+ // Set input and output formats before starting decode.

+ bool SetupFormats();

// Methods run on child thread.