Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(457)

Issue 836033006: Disable spdy tests for constant failures on Volantis bot (Closed)

Created:
5 years, 11 months ago by Ian Wen
Modified:
5 years, 11 months ago
Reviewers:
Bence, jbudorick, gone
CC:
chromium-reviews, klundberg+watch_chromium.org, yfriedman+watch_chromium.org, jbudorick+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Disable spdy tests for constant failures on Volantis bot Per https://uberchromegw.corp.google.com/i/clank/builders/instrumentation-volantis-clankium-lmp, all spdy related tests have failed on volantis bot. BUG=447837 Committed: https://crrev.com/f13f7dbe2ec8d008d7aefa4c625d297685e62435 Cr-Commit-Position: refs/heads/master@{#311401}

Patch Set 1 #

Total comments: 3

Patch Set 2 : Removed unnecessary lines #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -0 lines) Patch
M build/android/pylib/gtest/filter/net_unittests_disabled View 1 1 chunk +4 lines, -0 lines 0 comments Download

Messages

Total messages: 13 (3 generated)
Ian Wen
5 years, 11 months ago (2015-01-13 01:24:03 UTC) #2
jbudorick
https://codereview.chromium.org/836033006/diff/1/build/android/pylib/gtest/filter/net_unittests_disabled File build/android/pylib/gtest/filter/net_unittests_disabled (right): https://codereview.chromium.org/836033006/diff/1/build/android/pylib/gtest/filter/net_unittests_disabled#newcode51 build/android/pylib/gtest/filter/net_unittests_disabled:51: Spdy/SpdyNetworkTransactionTest.HTTP11RequiredRetry/7 This should start by disabling only these two. ...
5 years, 11 months ago (2015-01-13 01:28:11 UTC) #4
Bence
Please fix typo in CL description: s/Valantis/Volantis/. https://codereview.chromium.org/836033006/diff/1/build/android/pylib/gtest/filter/net_unittests_disabled File build/android/pylib/gtest/filter/net_unittests_disabled (right): https://codereview.chromium.org/836033006/diff/1/build/android/pylib/gtest/filter/net_unittests_disabled#newcode51 build/android/pylib/gtest/filter/net_unittests_disabled:51: Spdy/SpdyNetworkTransactionTest.HTTP11RequiredRetry/7 On ...
5 years, 11 months ago (2015-01-13 15:40:08 UTC) #5
Ian Wen
https://codereview.chromium.org/836033006/diff/1/build/android/pylib/gtest/filter/net_unittests_disabled File build/android/pylib/gtest/filter/net_unittests_disabled (right): https://codereview.chromium.org/836033006/diff/1/build/android/pylib/gtest/filter/net_unittests_disabled#newcode51 build/android/pylib/gtest/filter/net_unittests_disabled:51: Spdy/SpdyNetworkTransactionTest.HTTP11RequiredRetry/7 On 2015/01/13 15:40:08, Bence wrote: > On 2015/01/13 ...
5 years, 11 months ago (2015-01-13 19:27:52 UTC) #6
gone
lgtm
5 years, 11 months ago (2015-01-14 01:06:56 UTC) #7
jbudorick
lgtm
5 years, 11 months ago (2015-01-14 01:28:25 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/836033006/20001
5 years, 11 months ago (2015-01-14 01:31:00 UTC) #10
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 11 months ago (2015-01-14 03:19:14 UTC) #11
commit-bot: I haz the power
Patchset 2 (id:??) landed as https://crrev.com/f13f7dbe2ec8d008d7aefa4c625d297685e62435 Cr-Commit-Position: refs/heads/master@{#311401}
5 years, 11 months ago (2015-01-14 03:21:18 UTC) #12
Bence
5 years, 11 months ago (2015-01-14 20:52:25 UTC) #13
Message was sent while issue was closed.
A revert of this CL (patchset #2 id:20001) has been created in
https://codereview.chromium.org/800613008/ by bnc@chromium.org.

The reason for reverting is: https://crrev.com/852053002 fixes the tests, they
can be re-enabled..

Powered by Google App Engine
This is Rietveld 408576698