Issue 83603002: Improve and refactor push-to-trunk script.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 83603002: Improve and refactor push-to-trunk script. (Closed)

Created:
7 years, 1 month ago by Michael Achenbach

Modified:
7 years ago

Reviewers:
Jakob Kummerow

CC:
v8-dev

Base URL:
https://v8.googlecode.com/svn/branches/bleeding_edge

Visibility:
Public.

More Reviews

Description

Improve and refactor push-to-trunk script. Let change log formatter squash title and bug reference. Repair wrongly indented first line in change log. Add automatic rietveld reload of commit messages to enable late corrections. BUG= R=jkummerow@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=18057

Patch Set 1 : #

Patch Set 2 : Add system test with a non-mocked call to rietveld. #

Patch Set 3 : Presubmit correction. #

Created: 7 years ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+108 lines, -57 lines)			Patch
M	tools/push-to-trunk/common_includes.py	View		3 chunks	+8 lines, -13 lines	0 comments	Download
M	tools/push-to-trunk/push_to_trunk.py	View		5 chunks	+24 lines, -1 line	0 comments	Download
M	tools/push-to-trunk/test_scripts.py	View	1 2	14 chunks	+76 lines, -43 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Michael Achenbach

7 years ago (2013-11-25 14:20:47 UTC) #3

Message was sent while issue was closed.

Committed patchset #3 manually as r18057 (presubmit successful).

Expand Messages | Collapse Messages