Issue 835973003: Specs: Move the LayoutManager and RenderNode logic from Element to

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 835973003: Specs: Move the LayoutManager and RenderNode logic from Element to (Closed)

Created:
5 years, 11 months ago by Hixie

Modified:
5 years, 11 months ago

Reviewers:

CC:
mojo-reviews_chromium.org, ojan, esprehn, abarth-chromium

Base URL:
https://github.com/domokit/mojo.git@master

Target Ref:
refs/heads/master

Project:
mojo

Visibility:
Public.

More Reviews

Description

Specs: Move the LayoutManager and RenderNode logic from Element to Node since it is used by text nodes and document nodes as well. Specs: Make it possible for an element to set what layout manager class it uses. Specs: Expose the root layout manager as mutable state. Specs: Update the runloop to have more detail. Specs: Add support for transitions, by making the resolver for a value know when it has been called for the first time, and giving it access to the previous cached value, and letting it store state on the render node. Other sundry changes. Committed: https://chromium.googlesource.com/external/mojo/+/475929509c37eb9160ce8e3b855028e36ead690d

Patch Set 1 #

Created: 5 years, 11 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+186 lines, -79 lines)			Patch
M	sky/specs/dom.md	View	5 chunks	+35 lines, -18 lines	0 comments	Download
M	sky/specs/runloop.md	View	1 chunk	+24 lines, -6 lines	0 comments	Download
M	sky/specs/style.md	View	15 chunks	+127 lines, -55 lines	0 comments	Download

Messages

Total messages: 1 (0 generated)

Expand Messages | Collapse Messages

Hixie

5 years, 11 months ago (2015-01-05 22:33:46 UTC) #1

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
475929509c37eb9160ce8e3b855028e36ead690d.

Expand Messages | Collapse Messages