Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(11)

Issue 835963005: Chromecast: use PlayerTrackerImpl in BrowserCdmCast. (Closed)

Created:
5 years, 11 months ago by gunsch
Modified:
5 years, 11 months ago
Reviewers:
lcwu1
CC:
chromium-reviews, gunsch+watch_chromium.org, lcwu+watch_chromium.org, feature-media-reviews_chromium.org, eme-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Chromecast: use PlayerTrackerImpl in BrowserCdmCast. This is a simpler implementation of ::media::BrowserCdm's requirement to implement ::media::PlayerTracker. MediaDrmBridge (Android) does the same thing. R=lcwu@chromium.org BUG=None Committed: https://crrev.com/c02c29e735df5d26ea34241b0d10a42bf4d81933 Cr-Commit-Position: refs/heads/master@{#310566}

Patch Set 1 #

Total comments: 6

Patch Set 2 : address comments #

Total comments: 2

Patch Set 3 : removes unnecessary includes #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -37 lines) Patch
M chromecast/media/cdm/browser_cdm_cast.h View 1 2 chunks +4 lines, -5 lines 0 comments Download
M chromecast/media/cdm/browser_cdm_cast.cc View 1 2 1 chunk +6 lines, -32 lines 0 comments Download

Messages

Total messages: 9 (1 generated)
gunsch
5 years, 11 months ago (2015-01-06 01:19:18 UTC) #1
lcwu1
https://codereview.chromium.org/835963005/diff/1/chromecast/media/cdm/browser_cdm_cast.cc File chromecast/media/cdm/browser_cdm_cast.cc (right): https://codereview.chromium.org/835963005/diff/1/chromecast/media/cdm/browser_cdm_cast.cc#newcode10 chromecast/media/cdm/browser_cdm_cast.cc:10: #include "base/message_loop/message_loop_proxy.h" No longer needed. https://codereview.chromium.org/835963005/diff/1/chromecast/media/cdm/browser_cdm_cast.h File chromecast/media/cdm/browser_cdm_cast.h (right): ...
5 years, 11 months ago (2015-01-08 18:25:17 UTC) #2
gunsch
https://codereview.chromium.org/835963005/diff/1/chromecast/media/cdm/browser_cdm_cast.cc File chromecast/media/cdm/browser_cdm_cast.cc (right): https://codereview.chromium.org/835963005/diff/1/chromecast/media/cdm/browser_cdm_cast.cc#newcode10 chromecast/media/cdm/browser_cdm_cast.cc:10: #include "base/message_loop/message_loop_proxy.h" On 2015/01/08 18:25:17, lcwu1 wrote: > No ...
5 years, 11 months ago (2015-01-08 18:34:46 UTC) #3
lcwu1
lgtm % removing unnecessary headers. https://codereview.chromium.org/835963005/diff/20001/chromecast/media/cdm/browser_cdm_cast.cc File chromecast/media/cdm/browser_cdm_cast.cc (right): https://codereview.chromium.org/835963005/diff/20001/chromecast/media/cdm/browser_cdm_cast.cc#newcode10 chromecast/media/cdm/browser_cdm_cast.cc:10: #include "base/stl_util.h" I think ...
5 years, 11 months ago (2015-01-08 18:42:59 UTC) #4
gunsch
https://codereview.chromium.org/835963005/diff/20001/chromecast/media/cdm/browser_cdm_cast.cc File chromecast/media/cdm/browser_cdm_cast.cc (right): https://codereview.chromium.org/835963005/diff/20001/chromecast/media/cdm/browser_cdm_cast.cc#newcode10 chromecast/media/cdm/browser_cdm_cast.cc:10: #include "base/stl_util.h" Done: Looks like none of these are ...
5 years, 11 months ago (2015-01-08 18:58:32 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/835963005/40001
5 years, 11 months ago (2015-01-08 19:00:10 UTC) #7
commit-bot: I haz the power
Committed patchset #3 (id:40001)
5 years, 11 months ago (2015-01-08 19:46:21 UTC) #8
commit-bot: I haz the power
5 years, 11 months ago (2015-01-08 19:47:04 UTC) #9
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/c02c29e735df5d26ea34241b0d10a42bf4d81933
Cr-Commit-Position: refs/heads/master@{#310566}

Powered by Google App Engine
This is Rietveld 408576698