Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(452)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 835913002: Revert of move remaining virtual draw methods to onDraw (Closed)

Created:
5 years, 11 months ago by reed2
Modified:
5 years, 11 months ago
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Revert of move remaining virtual draw methods to onDraw (patchset #5 id:80001 of https://codereview.chromium.org/817723005/) Reason for revert: did this cause chromeos heap corruption on skp? Original issue's description: > move remaining virtual draw methods to onDraw > > BUG=skia: > > Committed: https://skia.googlesource.com/skia/+/2e0f7d53bba5438c9bf11ee5ccae2c301e348419 TBR=robertphillips@google.com,djsollen@google.com,bsalomon@google.com,mtklein@google.com NOTREECHECKS=true NOTRY=true BUG=skia: Committed: https://skia.googlesource.com/skia/+/e87e383351e1547b21d96d02bcd0c3cbbe0837f1

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+502 lines, -598 lines) Patch
M gyp/skia_for_android_framework_defines.gypi View 1 chunk +0 lines, -1 line 0 comments Download
M gyp/skia_for_chromium_defines.gypi View 1 chunk +0 lines, -1 line 0 comments Download
M include/core/SkCanvas.h View 15 chunks +14 lines, -38 lines 0 comments Download
M include/core/SkImage.h View 1 chunk +0 lines, -1 line 0 comments Download
M include/utils/SkDeferredCanvas.h View 2 chunks +27 lines, -25 lines 0 comments Download
M include/utils/SkDumpCanvas.h View 2 chunks +19 lines, -21 lines 0 comments Download
M include/utils/SkLuaCanvas.h View 2 chunks +20 lines, -21 lines 0 comments Download
M include/utils/SkNWayCanvas.h View 2 chunks +28 lines, -21 lines 0 comments Download
M include/utils/SkProxyCanvas.h View 2 chunks +25 lines, -21 lines 0 comments Download
M src/core/SkCanvas.cpp View 12 chunks +29 lines, -84 lines 0 comments Download
M src/core/SkPictureRecord.h View 2 chunks +21 lines, -24 lines 0 comments Download
M src/core/SkPictureRecord.cpp View 11 chunks +21 lines, -20 lines 0 comments Download
M src/core/SkRecorder.h View 2 chunks +41 lines, -21 lines 0 comments Download
M src/core/SkRecorder.cpp View 4 chunks +33 lines, -33 lines 0 comments Download
M src/pipe/SkGPipeWrite.cpp View 13 chunks +43 lines, -42 lines 0 comments Download
M src/utils/SkDeferredCanvas.cpp View 8 chunks +25 lines, -23 lines 0 comments Download
M src/utils/SkDumpCanvas.cpp View 4 chunks +18 lines, -51 lines 0 comments Download
M src/utils/SkLuaCanvas.cpp View 3 chunks +25 lines, -46 lines 0 comments Download
M src/utils/SkNWayCanvas.cpp View 3 chunks +26 lines, -23 lines 0 comments Download
M src/utils/SkProxyCanvas.cpp View 3 chunks +24 lines, -26 lines 0 comments Download
M src/utils/debugger/SkDebugCanvas.h View 2 chunks +34 lines, -21 lines 0 comments Download
M src/utils/debugger/SkDebugCanvas.cpp View 6 chunks +21 lines, -28 lines 0 comments Download
M tests/RecordDrawTest.cpp View 1 chunk +7 lines, -5 lines 0 comments Download
M tests/TileGridTest.cpp View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 4 (0 generated)
reed2
Created Revert of move remaining virtual draw methods to onDraw
5 years, 11 months ago (2015-01-05 12:48:19 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/835913002/1
5 years, 11 months ago (2015-01-05 12:49:19 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1) as https://skia.googlesource.com/skia/+/e87e383351e1547b21d96d02bcd0c3cbbe0837f1
5 years, 11 months ago (2015-01-05 12:49:43 UTC) #3
reed1
5 years, 11 months ago (2015-01-05 15:48:18 UTC) #4
Message was sent while issue was closed. 
A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/831253002/ by reed@google.com.

The reason for reverting is: test to see if it wasn't this CL that broke
chromeos.

Powered by Google App Engine
This is Rietveld 408576698